Bug#1021353: RFS: zvbi/0.2.37-1 -- Vertical Blanking Interval (VBI) utilities
Hi!
> The symbols look wrong:
> Defining and leaking basic syscall wrappers suggests something is pretty
wrong.
Running a readelf -s on libzvbi.so.0 does not show the exporting of
these functions, but libzvbi-chains.so does export these functions. I
looked into why this was and found the answer in src/chains.c and
daemon/chains.c: "This is a small wrapper which executes the VBI
application given on the command line while overloading several C
library calls (such as open(2) and read(2)) so that the application
can be forced to access VBI devices via the VBI proxy instead of
device files directly." So, exporting these functions is required for
the proxy to work with applications that do not implement zvbi's proxy
interface. I can add these symbols to the libzvbi0.symbols file or
suppress the dpkg-gensymbols warning, as these functions are not part
of the main library's public interface. Note that this symbols issue
has appeared in previous upstream releases as well. So I will suppress
the dpkg-gensymbols diff to avoid future confusion.
> Also: you may drop the lsb-base Depends altogether; lintian will complain
> until its next release but if you know the future you can avoid changing the
> same thing twice :)
> An upstreamish issue but since you might have a way to contact upstream:
> W: libzvbi-dev: national-encoding [usr/include/libzvbi.h]
> As we don't even support ancient encodings anymore, everyone who reads the
> header will get mojibake. Could you please convert everything to UTF-8?
Thank you for the feedback and for sponsoring! I am the upstream
maintainer so I just made both these changes and uploaded an updated
package to mentors :) I should have noticed the encoding warning but
only ran lintian on the source .deb package.
Ileana Dumitrescu
GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354
Reply to: