Control: tags -1 moreinfo
On Thu, 25 Aug 2022 15:49:14 -0300
Francisco M Neto <fmneto@fmneto.com> wrote:
> I am looking for a sponsor for my package hydrapaper:
hi Francisco,
took a look but this package doesn't appear ready for uploading:
* changelog: is that bug really fixed just by switching to gtk4?
There's still no dependency on python3-pil while the program is
directly importing from that module!
* copyright: missing entry for the appdata xml file (cc0).
* patches: forwarded upstream but the related merge request was
closed by yourself; why? is the patch still needed?
* watch: multiple empty lines at EOF
* control:
+ short and long description could use an update (upstream describes
the program as a "Wallpaper manager with multi monitor support";
mention additional supported desktop environments, etc.)
+ unused build-dep on python3-willow?
+ the build-dep on libwnck-3-dev appears to server no other purpose
than pulling in the dbus-1 pkgconfig file from libdbus-1-dev; if
so, you should depend on the latter directly
+ libhandy-1-0 is a hard dependency of gir1.2-handy-1 but not
imported or linked directly in hydrapaper, so no need to duplicate
that here
+ gir1.2-handy-1 itself looks isn't used at all in the new upstream
release so that should go too
+ ${shlibs:Depends} is pointless for an arch:all Python package
Program fails to start (missing dep on something to ensure gi gtk4 is
present, installing gir1.2-gtk-4.0 seems to fix that):
Traceback (most recent call last):
File "/usr/bin/hydrapaper", line 60, in <module>
gi.require_version('Gtk', '4.0')
File "/usr/lib/python3/dist-packages/gi/__init__.py", line 129, in require_version
raise ValueError('Namespace %s not available for version %s' %
ValueError: Namespace Gtk not available for version 4.0
Same for adw:
Traceback (most recent call last):
File "/usr/bin/hydrapaper", line 62, in <module>
gi.require_version('Adw', '1')
File "/usr/lib/python3/dist-packages/gi/__init__.py", line 126, in require_version
raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace Adw not available
Probably missing a dependency on python3-dbus too (imported by
hydrapaperd)? And python3-pil as mentioned earlier.
Please at least take a cursory look at upstream code when packaging
major version bumps, and test your packages on a reasonably clean
testing/unstable install before asking for sponsorship.
Consider adding some basic automated testing, as even a trivial
autopkgtest that just calls `hydrapaper --help' would have failed
with errors similar to the ones listed above.
Attachment:
pgp9yyK6Mv6NW.pgp
Description: OpenPGP digital signature