Bug#1016864: RFS: librcc/0.2.13+ds-1 [QA] -- RusXMMS Charset Conversion library
Hi Tobi,
Thank you for the review. I've just uploaded a revised version to
Debian Mentors.
On Wed, 24 Aug 2022 at 00:21, Tobias Frost wrote:
>
> Package: sponsorship-requests
> Followup-For: Bug #1016864
> Control: tags -1 moreinfo
>
> Hi Hugh,
>
> Thanks for working on librcc!
>
> here's a quick (incomplete) review:
>
> + Update Vcs-* fields and point to GitHub.
>
> VCS* is for the packaging, not for upstream. The link on Github seems not to
> have the (latesdt) packaging
Good point. I've dropped the Vcs-* fields, since there is no Salsa
packaging repository at the moment.
I checked the GitHub repository and it has the latest version 0.2.13.
Older versions are available from a different (non-GitHub) repository.
> - Adding new packagages
>
> I'd suggest to upload to experimental then, to clear NEW first.
The new version now targets experimental.
> This to avoid breaking reverse depdendenies (moc)
>
> Speaking of, have you checked if moc still works with the new package
> (is the new version ABI compatible?)
I was able to build moc against librcc 0.2.13 without issue. According
to the control file, moc depends on librcc0 (>= 0.2.12).
> - Multiarch d/*.install
>
> Instead of using "*" for the multiarch path, you can use
> ${DEB_HOST_MULTIARCH} with modern debhelper.
I've updated the paths to use the variable format instead of an asterisk.
> - static library
>
> As you are modernizing the package, time to drop the static library?
Yes, it's unlikely anyone is using it.
--
Hugh
Reply to: