[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1017815: RFS: rumur/2022.08.20-1 [RC] -- model checker for the Murphi language



Package: sponsorship-requests
Followup-For: Bug #1017815

Hi Matthew,

thanks for the updated package fixing an RC bug!

I have is some feedback regarding it:
- The format of d/changelog is a bit unusual, usually there are no
  blank lines between entries.

- d/changelog should document every change to the Debian packaging,
  there are many changes that are not documented:
  - update watch file
  - update Standard-Version
  - updates to d/control, versions of depdendencies.

- d/copyright needs updating, at least some years.
  A remark on the copyright for debien/*: You've choosen
  a different license here than the upstream license. This
  is of course your choice, but if the license differ this could
  make it difficult to include stuff (like patches) to upstream,
  as GPL-3 and unlicense are not compatible in the GPL…
  As you are the only person working on the package and upstream,
  that be easily fixed by relicensing the debian directory to
  unlicense as well…

- There are a lots of tests skipped due to missing xmllint…
  Is there a missing B-D on libxml2-utils?

Those are not critcial issues, but please consider them for later
revisions of your package. So I'm going to upload your package soon.

Thanks for your contribution to Debian!

-- 
tobi

Reply to: