[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1016875: RFS: freefilesync/11.23-1 [ITP] -- cross-platform file sync utility, gpl release



X-Debbugs-CC: fabstz-it@yahoo.fr
Control: tags -1 +moreinfo

Hi,

On Mon, 08 Aug 2022 19:30:32 +0200 Fab Stz <fabstz-it@yahoo.fr> wrote:
> Package: sponsorship-requests
> Severity: wishlist
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "freefilesync":
> 
>  * Package name    : freefilesync
>    Version         : 11.23-1
>    Upstream Author : Zenju <zenju@freefilesync.org>
>  * URL             : https://freefilesync.org/
>  * License         : GPL-3.0
>  * Vcs             : https://salsa.debian.org/bastif/freefilesync
>    Section         : utils
> 
> The source builds the following binary packages:
> 
>   freefilesync - cross-platform file sync utility, gpl release
> 
> To access further information about this package, please visit the
following 
> URL:
> 
>   https://mentors.debian.net/package/freefilesync/
> 
> Alternatively, you can download the package with 'dget' using this
command:
> 
>   dget -x https://mentors.debian.net/debian/pool/main/f/freefilesync/
> freefilesync_11.23-1.dsc

I am curious on the current arrangement of your deb packaging. Specifically:

* Why there are many separate ffs_* patches in debian/patches/? Where did
they originate from? If they originates from upstream (FreeFileSync), why
aren't they incorporated into upstream source code?

* You are providing .desktop files under debian/desktop/. Does that mean
that upstream author is not providing any .desktop files so that you have to
write them yourself?

* Please do not hardcode g++-12:native in the Build-Depends field. A sane
environment should already have provided the proper g++. It could be g++ 12
or other versions.

* You wrote Maintainer: B. Stack <bgstack15@gmail.com> in debian/control
file, which looks falty to me. The maintainer should be package maintainer,
not upstream software author, unless the upstream author (B. Stack) will be
maintaining Debian package as well.

* You indicated "Multi-Arch: foreign" in debian/control file. However
according to https://wiki.debian.org/MultiArch/Hints#ma-foreign , M-A:
foreign only applies to Architecture: all packages. Your package is not of
Architecture: all.

Thanks,
Boyuan Yang

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: