[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1006020: RFS: pacman-package-manager/6.0.1-1 [ITP] -- Simple library-based package manager



On Sat, 19 Feb 2022 00:13:37 -0500 Ben Westover
<kwestover.kw@gmail.com> wrote:
> Package: sponsorship-requests
> Severity: wishlist
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "pacman-package-manager":
> 
>   * Package name    : pacman-package-manager
>     Version         : 6.0.1-1
>     Upstream Author : Pacman Development Team
<pacman-dev@archlinux.org>
>   * URL             : https://archlinux.org/pacman/
>   * License         : GPL-2+, MIT, curl, unlicense, public-domain
>   * Vcs             : https://salsa.debian.org/benthetechguy/pacman
>     Section         : admin
> 
> It builds those binary packages:
> 
>    pacman-package-manager - Simple library-based package manager
>    libalpm13 - Arch Linux Package Management library
>    makepkg - Arch Linux package build utility
> 
> To access further information about this package, please visit the 
> following URL:
> 
>    https://mentors.debian.net/package/pacman-package-manager/
> 
> Alternatively, one can download the package with dget using this
command:
> 
>    dget -x 
>
https://mentors.debian.net/debian/pool/main/p/pacman-package-manager/pacman-package-manager_6.0.1-1.dsc
> 
> Changes for the initial release:
> 
>   pacman-package-manager (6.0.1-1) unstable; urgency=medium
>   .
>     * Initial Package (Closes: #511994)

Hi,

I can sponsor this.

A few remarks, aside from the keyring change mentioned by Michel:

- all the doc build-dependencies (asciidoc, doxygen, help2man) can be
marked with <!nodoc> so that nodoc builds can be done
- are curl and fakechroot really needed to build the package, or are
they just used by self tests? if they are used only by tests, mark them
as <!nocheck>
- is pkgconf really needed instead of pkgconfig, which is the default?
- you need to add a libalpm-dev and ship the headers, pkgconfig file,
unversioned .so and manpage in it, instead of in libalpm13, and remove
the lintian override
- libalpm13 is missing Pre-Depends: ${misc:Pre-Depends}
- no need to specify the libarchive-tools and libgpgme11 dependencies
on libalpm13, they will be autogenerated
- does libalpm13 really need to depend on the binary curl executable?
- makepkg should not depend on build-essential nor on sudo
- no need to manually specify the dependency on libalpm13 in makepkg,
it will be autogenerated
- libalpm13 is missing the symbols file, you can generate it after
building the library with:
   dpkg-gensymbols -plibalpm13 -edebian/tmp/usr/lib/x86_64-linux-gnu/libalpm.so.13.0.1 -Odebian/libalpm13.symbols
- makepkg is missing a dependency on ${perl:Depends}
- are you sure all of these can run on GNU/Hurd and debian/kFreeBSD? If
not, use 'linux-any' instead of 'any' as the architecture
- it is not necessary anymore to specify the build system in
debian/rules, meson is autodetected
- use execute_before_dh_auto_clean instead of override_
- 228 tests fail when running in a pbuilder chroot, this is a strong
hint that the build might fail once uploaded
- you should try and fix the reproducible build, rather than disabling
it in the CI
- the GPL-2+ in debian/copyright says in the last paragraph:
   "On Debian systems, the full text of the GNU General Public
    License version 3 can be found in the file"
  instead of version 2

-- 
Kind regards,
Luca Boccassi

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: