Bug#1010663: RFS: strawberry/1.0.4-1 [ITP] -- Audio player and music collection organizer
On 02/06/2022 07:27, Jeroen Ploemen wrote:
On Sun, 29 May 2022 11:52:53 +0100
Peter <peter@pblackman.plus.com> wrote:
Updated copyright and reverted to Qt5
Thanks, qt5 seems to be the way to go for now.
Also, I found that the Qt6 version on Debian had very a small font, with no obvious way of enlarging it.
If Strawberry is accepted into Debian, I'd consider updating the package to build both Qt5 & Qt6 versions.
With a Strawberry-common, maybe the Qt5 & Qt6 binaries could co-install?
Looks like there's an error in the dbus copyright entry though, given
that the file linked in the comment is under LGPL rather than GPL?
My bad. Fixed.
And more importantly: the comment only deals with one of the xml
files, but (as far as I can tell) these do not all originate from a
single source. For example, org.kde.KGlobalAccel.*.xml files appear
in the kglobalaccel package; the Udisks stuff might well be based on
[2]; mpris/MediaPlayer2 in turn appears in [3].
I suspect some of the org.freedesktop.*.xml files on the other hand
could be based directly on dbus specs [1] or similar generic interface
definitions for use with qdbusxml2cpp, possibly autogenerated by
qdbus along the lines of:
`QT_SELECT=5 qdbus org.freedesktop.Notifications /org/freedesktop/Notifications org.freedesktop.DBus.Introspectable.Introspect`
I've created separate Files paragraphs for each group of files.
(I'm not sure what the impact of auto-generation is on the copyright.
I notice that in [3], the author is the upstream application author,
no reference to org.freedesktop)
Aside from the dbus xml stuff: what exactly do you mean by the comment
in the GPL-3 license paragraph?
I'm confused regarding GPL-3 & GPL-3+. We now have a License paragraph for GPL-3 that excludes later versions,
but the full text in
/usr/share/common-licenses/GPL-3
https://www.gnu.org/licenses/gpl-3.0.html
both include it!
I'm wondering whether it would be best to have a single GPL-3 licence, or at least to remove the "(version 3 only)".
ISTM that failing to explicitly state in a source file header that a later version can be used, does not necessarily
mean that right is excluded,
especially when its explicitly included in the linked full text....
Anyway, up to you, I have just removed the comment for now.
[1]https://dbus.freedesktop.org/doc/dbus-specification.html
[2]https://salsa.debian.org/utopia-team/udisks2/-/blob/debian/master/data/org.freedesktop.UDisks2.xml
[3]https://sources.debian.org/src/mpdris2/0.9.1-1/src/mpDris2.in.py/#L133
Thanks for the links. I've put [1] into the copyright file.
Cheers,
Peter
Uploaded to Salsa & Mentors.
Reply to: