Control: tags -1 moreinfo On Sun, 10 Apr 2022 02:36:55 +0500 Lev Borodin <faunris@gmail.com> wrote: > I am looking for a sponsor for my package importlab: hi Lev, as mentioned on irc, really solid work! A few comments and suggestions: Copyright: * incorrect year for the upstream copyright (sources mention 2017); * please use standard license shortnames (missing dash, see [1]); * the standalone license paragraph should include the license headers instead of just a <see somewhere in common-licenses> oneliner. Rules: consider using debian/clean respectively execute_before_dh_installman instead of the two overrides. This would make the rules file even easier to read and avoid the repeated hardcoding of the buildsystem. Tests: the upstream testsuite looks very usable as a non-trivial autopkgtest (replacing the trivial autopkgtest-pkg-python). The general approach for a python package such as this is to copy the tests and testdata to an empty directory, then loop over all supported python versions; see [2] for a well written example. And lastly, please enable the CI on salsa: it's a great quality control tool and a real timesaver for reviewers too. [1] https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-short-name [2] https://sources.debian.org/src/pyliblo/0.10.0-5/debian/tests/ Please remove the moreinfo tag (and CC me directly) once you have an updated package ready.
Attachment:
pgpWx1nBZQUGu.pgp
Description: OpenPGP digital signature