Hi Adam, Thank you for reviewing my work. I believe I have addressed all of these issues but had a question on one. On Sunday, February 20th, 2022 at 3:41 AM, Adam Borowski <kilobyte@angband.pl> wrote: > I'm afraid the package fails to build, it needs a Build-Depend on liblz4-dev. Yes, this was an omission. Thank you for catching this. > Some files are "Copyright 2019, OpenTelemetry Authors" without being mentioned in debian/copyright. Also an omission. I didn't scan down the protobuf directory but they are now cited in the copyright. > You install /usr/bin/srpc_generator to libsrpc-dev yet > /usr/share/man/man1/srpc_generator.1.gz to libsrpc -- they should be in > the same package. After talking to the upstream authors, I've placed the manpage and srpc_generator in libsrpc. > The runtime library package should have a soname included in its name; > this will allow ABI bumps in the future. I was doing this through the links file and planned to update on each release. Is this not appropriate? Is it a compiled flag? Should I patch the CMake file or work with the upstream to change it? > The -dev package can't be "Multi-Arch: foreign" as its architecture must > match whatever [Build-]Depends on it. Currently, if you want to build > a riscv64 package on an amd64 host, M-A: foreign would allow: > compiler:riscv64> > > libsrpc-dev:amd64 > libsrpc0:amd64 > which won't work. I see. For now, I've removed the multi-arch field. I was working from a template. Please let me know if these changes are sufficient. Best, Lance Lin <lqi254@protonmail.com> GPG Fingerprint: 8CAD 1250 8EE0 3A41 7223 03EC 7096 F91E D75D 028F
Attachment:
signature.asc
Description: OpenPGP digital signature