Control: owner -1 !
Hi Joshua,
Joshua Peisach <itzswirlz2020@outlook.com> writes:
> Package: sponsorship-requests
> Severity: wishlist
>
> Dear mentors,
>
> I am looking for a sponsor for my package "kotlin-mode":
>
> * Package name : kotlin-mode
> Version : 20210917git0-1
> Upstream Author : Emacs Kotlin Mode Maintainers
> * URL : https://github.com/Emacs-Kotlin-Mode-Maintainers/kotlin-mode
> * License : GPL-3+
> * Vcs : https://salsa.debian.org/emacsen-team/kotlin-mode
> Section : lisp
>
I'd be happy to sponsor this one! Thank you for your work, and yes, I
agree that this should be part of Debian. Here are a couple of points that need
to be worked on, one nitpick, and one enhancement.
Copyright either isn't accurate or is missing a citation (or copy of
email as proof of the asserted copyright). Using a tool like
silversearch-ag (or similar) and searching for "copyright", "©", or
'\(c\)' will reveal the inconsistency. Please list documented copyright
holders with documented copyright years, or provide proof for what is
currently asserted.
Short description needs to mention Emacs. Nitpick: first letter should
not be capitalised.
Long description: this was copy and pasted and needs to be rewritten for
a Debian context.
Nitpick: Section: lisp is acceptable, but lintian is making an overclaim
when it complains about this. Noninteractive libraries are definitely
section: lisp, but this package is used to interactively edit Kotlin
files so should be Section: editors.
Rules: We use dh-elpa and not Cask, and Cask doesn't integrate with
Debhelper, so the comment is misleading. Overridden targets can empty,
and there is no need for those colons. If you'd like to make build log
output nicer, here's a neat trick for the body of override_dh_auto_build:
@echo Ignoring upstream Makefile and building/installing with dh-elpa.
I'll take a more in-depth look tomorrow (eg: I didn't check to see if it
FTBFS or if autopkgtests function).
Cheers,
Nicholas
Attachment:
signature.asc
Description: PGP signature