[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#996592: RFS: workflow/0.9.8-1 [ITP] -- Parallel computing and asynchronous web server engine



I've uploaded a new version of workflow with the suggested changes.

>>>> The filenamemangle in the debian/watch file is not correct.  Please test it with uscan.

Unfortunately I am not able to reproduce any errors with the watch file. uscan also does not return any errors. Is there something specific I should look at?

>>>> Please consider relicensing debian/* or at least debian/patches/* to the same license as upstream
>>>> (Apache 2). The problem with the debian/* license being more restrictive than upstream is that your
>>>> patches cannot be used by upstream and you might exclude possible reverse dependencies from using
>>>> the Debian package.

This is helpful feedback and I've changed the copyright to Apache-2.0.

>>>> You reference the non-existing https://salsa.debian.org/debian/workflow.
>>>> If you want to maintain your package there, I can create that repository for you on sponsoring.
>>>> Else, please remove the references.

Yes, please create the repository. My salsa account name is @linqigang.

>>>> You can include the cmake files in the -dev package if there are no problems with them.

Ok.

>>>> There are missing copyright notices and BSD licenses in src/util/crc32c.*

I reviewed the files and crc32c.h has the "BSD 2-Point" license text without explicitly calling it as such. crc32c.c has a copyright notice and free distribution notice but it is non-traditional and added by the original author, Mark Adler. Is this sufficient?

>>>> Please fix lintian's duplicate-short-description and debian-rules-uses-as-needed-linker-flag.

I removed the flag and verified that the output of lintian no longer shows the issue

>>>> You should not need to build depend on dh-exec with debhelper 13.

Thank you, Bastian and Niels, for your guidance. I've removed the dependency and updated the .links file.

Lance Lin <lqi254@protonmail.com>
GPG Fingerprint:  8CAD 1250 8EE0 3A41 7223  03EC 7096 F91E D75D 028F

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: