[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#934297: RFS: bibtexconv



Hi,

version 1.3.1~test4 closes bug #975076 now. I added the Closes: to the
change that actually fixed the bug (update of the debian/watch file).

If there are no other problems, I could create release 1.3.1.

Den 06.11.2021 23:31, skrev Bastian Germann:
> On 06.11.21 21:30, Thomas Dreibholz wrote:
>> Hi,
>>
>> version test3 makes the following updates:
>>
>>   * changelog is merged, i.e. new entry + all old entries from
>> unstable. In the new entry, all items
>>     from the changes after the latest "unstable" version are merged.
>>   * Installation of examples with dh_installexamples.
>>   * Installation of manpages with dh_installman.
>>   * Updated standards version
>>   * Removed empty test/control
>>   * Removed OpenSSL exception from debian/copyright. BibTeXConv uses
>> LibSSL's MD5 computation
>>     function (from shared library). In addition, it uses (by default)
>> libcurl with OpenSSL (from
>>     shared library).
>>
>> If the changes are okay, I would create an upstream release 1.3.1
>> (i.e. without ~testX), and a new package.
>>
>> Den 04.11.2021 22:54, skrev Bastian Germann:
>>> Control: tags -1 moreinfo
>>>
>>> On Thu, 02 Jan 2020 12:18:40 +0100 Tobias Frost <tobi@debian.org>
>>> wrote:
>>>> - Can you please merge the d/changelog entries for (in Debian)
>>>> unreleased versions?
>>>> - The Debian changelog seems incomplete, I see (packaing) changes
>>>> which
>>>> are not documented. Please also try to expand a bit on the changes,
>>>> e.g
>>>> did the SV update require you add changes? (documenting "why has this
>>>> changed" is important as additional information to the "what")
>>>
>>> These were fixed.
>>>
>>>> - You do not need to specify the standards versions 4th digit, this
>>>> digit is for editorial changes only. So it is sufficient to declare
>>>> compatiblitliy with e.g 4.4.1 (which has been released since you put
>>>> this package to mentors)
>>>> - d/test/control is a empty file. I don't think that is right.
>>>>
>>>> nitpicks:
>>>> d/compat can be obsoleted. (
>>>> https://nthykier.wordpress.com/2019/01/04/debhelper-compat-12-is-now-released/
>>>>
>>>> )
>>>
>>> Please correct these.
>>>
>>> - Where do you get the OpenSSL exception from? I know you are the
>>> upstream but this exception should be present in the source as well
>>> or should be removed from d/copyright. Debian does not require it
>>> any longer.
>>>
>>> - Please change the version and the origtarxz to actually match the
>>> released version/file. No ~test0
>>>
>>> - Add "(Closes: #975076)" to d/changelog's "New upstream release."
>>> line.
>>>
>>> With these changes I am going to sponsor the package. Please untag
>>> moreinfo when you are done.
>
> Still I cannot see the changelog closing the bug.

-- 
Best regards / Mit freundlichen Grüßen / Med vennlig hilsen

=======================================================================
 Thomas Dreibholz

 SimulaMet -- Simula Metropolitan Centre for Digital Engineering
 Centre for Resilient Networks and Applications
 Pilestredet 52
 0167 Oslo, Norway
-----------------------------------------------------------------------
 E-Mail:     dreibh@simula.no
 Homepage:   http://simula.no/people/dreibh
=======================================================================


Attachment: OpenPGP_signature
Description: OpenPGP digital signature


Reply to: