[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#990407: Acknowledgement (RFS: nftfw/0.9.4-1 [ITP] -- nftables firewall builder for Debian)



Control: tags -1 moreinfo

On Thu, 1 Jul 2021 10:54:07 +0200 santiagorr@riseup.net wrote:
Thanks for your work developing nftfw and packaging it for debian! Here you
have some comments:

* you have a master branch (that includes the debian/ dir). It is a common
  practice to have the debian packaging branch separated from the upstream
  code (including the tarball). See the candidate DEP-14.
  https://dep-team.pages.debian.net/deps/dep14/

* the watch file stores the downloaded upstream tarball as:

  nftfw_0.9.4.orig.tar.gz -> '<project>-0.9.4.tar.gz'
  '<project>-0.9.4.tar.gz'

  you can try with `uscan --verbose --download --download-current-version`

  Also, the .orig.tar.gz I can download with your .dsc is different from the
  .orig.tar.gz I download using uscan. It seems you have removed the debian/
  dir.

* do you have any reason for not using salsa? (it is not mandatory, I am just
  curious). Keep in mind that using Salsa would make it easier to make use of
  common Debian tools, such as Salsa CI:
  https://salsa.debian.org/salsa-ci-team/pipeline/

* building the package modifies debian/postinst (by the make_etc_lists). Could
  you please explain what is the goal of make_etc_lists? Why do you need it?

When you have addressed Santiago's comments please untag moreinfo.


Reply to: