Re: Bug#983146: 983146 RFS: bung/3.0.7-2 [ITP] -- backup next generation
Hi Charles,
(I'm sorry I did not have time for a complete review, so this one is possibly
incomplete and focuses mostly on that what lintian told me.)
There are a few typos:
I: bung: typo-in-manual-page usr/share/man/man5/bung-common.5.gz Overriden Overridden
I: bung: typo-in-manual-page usr/share/man/man5/bung-common.5.gz minumum minimum
I: bung: typo-in-manual-page usr/share/man/man5/check_hotplug_usage.5.gz decribed described
I: bung: typo-in-manual-page usr/share/man/man5/hotplug_bu.5.gz decribed described
I: bung: typo-in-manual-page usr/share/man/man5/hotplug_bu_launcher.5.gz decribed described
I: bung: typo-in-manual-page usr/share/man/man5/mysql_bu.5.gz decribed described
I: bung: typo-in-manual-page usr/share/man/man5/openldap_bu.5.gz decribed described
I: bung: typo-in-manual-page usr/share/man/man5/postgres_bu.5.gz decribed described
I: bung: typo-in-manual-page usr/share/man/man5/rsync_bu.5.gz decribed described
I: bung: typo-in-manual-page usr/share/man/man5/super_bu.5.gz decribed described
I: bung: typo-in-manual-page usr/share/man/man5/sysinfo_bu.5.gz varaibles variables
I: bung: typo-in-manual-page usr/share/man/man5/template_file.5.gz folllowed followed
I: bung: typo-in-manual-page usr/share/man/man5/templated_bu.5.gz decribed described
I: bung: typo-in-manual-page usr/share/man/man5/templated_bu.5.gz decribed described
I: bung: typo-in-manual-page usr/share/man/man8/bung-common.8.gz decribed described
I: bung: typo-in-manual-page usr/share/man/man8/check_hotplug_usage.8.gz decribed described
I: bung: typo-in-manual-page usr/share/man/man8/hotplug_bu.8.gz decribed described
I: bung: typo-in-manual-page usr/share/man/man8/hotplug_bu_launcher.8.gz decribed described
I: bung: typo-in-manual-page usr/share/man/man8/mysql_bu.8.gz decribed described
I: bung: typo-in-manual-page usr/share/man/man8/openldap_bu.8.gz decribed described
I: bung: typo-in-manual-page usr/share/man/man8/postgres_bu.8.gz decribed described
I: bung: typo-in-manual-page usr/share/man/man8/remote_agent.8.gz decribed described
I: bung: typo-in-manual-page usr/share/man/man8/rsync_bu.8.gz decribed described
I: bung: typo-in-manual-page usr/share/man/man8/rsync_restore.8.gz decribed described
I: bung: typo-in-manual-page usr/share/man/man8/super_bu.8.gz decribed described
I: bung: typo-in-manual-page usr/share/man/man8/sysinfo_bu.8.gz decribed described
I: bung: typo-in-manual-page usr/share/man/man8/templated_bu.8.gz decribed described
A spare manpage:
I: bung: spare-manual-page usr/share/man/man8/bung-common.8.gz
Old Standard Version:
I: bung source: out-of-date-standards-version 4.1.4 (released 2018-04-05) (current is 4.5.1)
(See the Debian Policy for the upgrade checklist; this will then fix also:
P: bung source: silent-on-rules-requiring-root
Old Compat level, using d/compat:
P: bung source: package-uses-old-debhelper-compat-version 11
P: bung source: uses-debhelper-compat-file
Others (partly needs to be checked if valid)
I: bung source: older-debian-watch-file-standard 3
I: bung: possible-documentation-but-no-doc-base-registration
- d/patches/series can be deleted -- there are no patches
- maybe add a d/source/metadata -- see https://wiki.debian.org/UpstreamMetadata
- d/README.Debian is not needed, contains no important infromation. delete it.
- d/changelog targets "UNRELEASED". (Maybe useful: Use dc -r "" to update it and
update the timestamp.)
- d/control, package description.
- The short package description should explain a bit more a bout bung than
"backup system".
- The extended description maybe should be not only a bullet point list,
more free text elaborating a bit more about bung, why one wants it and
its key features. (I know this is usually quite hard, maybe take a look at
other packages how this is usually done)
Again, sorry, ENOTIME for a complete review, but you can work on those (small) issues
already :)
On Sat, Jun 19, 2021 at 09:12:54AM +0530, Charles wrote:
> Thanks tobi, I appreciate the guidance
>
> bung/3.0.7-2 is now at https://mentors.debian.net/package/bung (3.0.7-2 is
> signed, 3.0.7-1 was not)
--
Cheers,
tobi
Reply to: