Bug#969446: RFS: vguitar-2.6 [ITP] -- Play Guitar in any term window. Use with a MIDI synthesizer (qsynth)

[Tobias Frost <tobi@debian.org>]

Control: tags -1 moreinfo

Hi Nick

let me follow up. Base of this review is this dsc file:

9a88dec1dfb2f225e8a4d07d205e357aaab926d55b302349c1cda328ddb33fc6  vguitar_2.8-
1.dsc

(Please consider using mentors.debian.net to provide the package, as it has some
nice features that helps in the sponsoring process both the sponsor and the sponsoree,
eg. by the diagnostic features it has.)

- Lintian has several complaints; I've added some hints. Its possible that the
  hardening is a false positive, did not check; refer to the hardening debian wiki page.

W: vguitar source:
ancient-standards-version 3.9.6 (released 2014-09-17) (current is 4.5.1)
W: vguitar: debian-changelog-has-wrong-day-of-week 2020-09-28 is a Monday
^^^ hint: always use dch(1) to manipulate d/changelogs. It also has a convienient
"update date" function when ready for release: "dch -r"

W: vguitar source: no-debian-changes
^^ please read the upstream guide. https://wiki.debian.org/UpstreamGuide
Likely caused by having the debian/ directory in the upstream tarball, so read
that section carefully.

W: vguitar source: no-nmu-in-changelog
W: vguitar source: source-nmu-has-incorrect-version-number 2.8-1
(^^ those two above are false positive)
W: vguitar: syntax-error-in-debian-changelog line 5 "unrecognised line"
I: vguitar: hardening-no-bindnow usr/bin/vguitar
I: vguitar: hardening-no-fortify-functions usr/bin/vguitar
I: vguitar source: older-debian-watch-file-standard 3
X: vguitar source: debian-watch-does-not-check-gpg-signature
P: vguitar source: insecure-copyright-format-uri http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
P: vguitar source: silent-on-rules-requiring-root
^^ see debian policy document.
P: vguitar source: trailing-whitespace debian/changelog (line 5)
P: vguitar source: trailing-whitespace debian/changelog (line 6)
P: vguitar source: trailing-whitespace debian/control (line 17)
P: vguitar source: trailing-whitespace debian/control (line 18)
P: vguitar source: trailing-whitespace debian/rules (line 45)
X: vguitar source: upstream-metadata-file-is-missing

- For the whitespace errors, take a look at wrap-and-sort(1)

- There is an (empty) tar in the source tarball. Likely shouldnt be there.
- Possibly the vgituar.1-save is also a stray file.

- d/changelog
  - has errors
  - see lintian above and
  - it still says "UNRELEASED"*

- d/rules
  - Lots of comments. please remove them.*
  - (As you use help2man), the manpage needs to be generated at build time.

- d/copyright:
  - License identifier should be GPL-3+ ("or later") not GPL-3 ("exactly 3")

- d/watch
  - lots of boilerplate comments, please remove them as well. *


* already an earlier review finding. Please make sure to consider those,
as it generates uneeded extra work for all parties. TIA.

I'm stopping here and ask you to revisit the previous review comments;
please update the package accordingly and then remove the moreinfo tag.

-- 
cheers,
tobi