Bug#989303: RFS: backintime/1.2.1-3 [RC] -- simple backup/snapshot system

[Fabian Wolff <fabi.wolff@arcor.de>]

Package: sponsorship-requests
Severity: important

Dear mentors,

I am looking for a sponsor for an upload of the 'backintime' package.

The upload fixes a release critical bug in the current version of the
package (#946349). A patch was provided in the Debian bug tracking
system and has since been applied upstream.

My changes in this upload consist solely of cherry-picking the fix for
#946349. Therefore, this upload is a targeted fix for a release
critical bug and should qualify as an appropriate change according to
the bullseye freeze policy [1].

Since this package neither is a key package nor has any autopkgtests,
it will require manual review by the release team. Bullet point five
of "Applying for an unblock" in the freeze policy states that

  If the diff is small and you believe it will be approved, you can
  upload it to unstable before filing the unblock request to avoid a
  round-trip.

I suppose this applies here, which is why I'm looking for a sponsor
for this upload now. The package is available on Salsa as well as on
Mentors:

  https://salsa.debian.org/jmw/pkg-backintime
  https://mentors.debian.net/package/backintime/

I have also attached the debdiff of my changes vs. the current version
of the package in testing/unstable.

Thanks for your help!
Fabian

[1] https://release.debian.org/bullseye/freeze_policy.html

diff -Nru backintime-1.2.1/debian/changelog backintime-1.2.1/debian/changelog
--- backintime-1.2.1/debian/changelog	2019-10-30 22:35:50.000000000 +0100
+++ backintime-1.2.1/debian/changelog	2021-05-31 15:14:50.000000000 +0200
@@ -1,3 +1,10 @@
+backintime (1.2.1-3) unstable; urgency=medium
+
+  * Cherry-pick patch for #946349 from upstream Git repository
+    (Closes: #946349).
+
+ -- Fabian Wolff <fabi.wolff@arcor.de>  Mon, 31 May 2021 15:14:50 +0200
+
 backintime (1.2.1-2) unstable; urgency=medium
 
   * Source-only reupload after the package has been in the NEW queue
diff -Nru backintime-1.2.1/debian/patches/00-fix-946349.patch backintime-1.2.1/debian/patches/00-fix-946349.patch
--- backintime-1.2.1/debian/patches/00-fix-946349.patch	1970-01-01 01:00:00.000000000 +0100
+++ backintime-1.2.1/debian/patches/00-fix-946349.patch	2021-05-31 15:14:50.000000000 +0200
@@ -0,0 +1,39 @@
+Description: Cherry-pick fix for #946349 from upstream repository
+Origin: upstream, https://github.com/bit-team/backintime/commit/7f6f570a01e7e0a623e670baaf63eaaf879948c4
+Bug: https://github.com/bit-team/backintime/issues/974
+Bug-Debian: https://bugs.debian.org/946349
+Last-Update: 2021-05-31
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/common/mount.py
++++ b/common/mount.py
+@@ -648,7 +648,7 @@
+         """
+         tools.mkdir(self.mount_root, 0o700)
+         tools.mkdir(self.hash_id_path, 0o700)
+-        tools.mkdir(self.currentMountpoint, 0o700)
++        tools.mkdir(self.currentMountpoint, 0o700, False)
+         tools.mkdir(self.lock_path, 0o700)
+ 
+     def mountProcessLockAcquire(self, timeout = 60):
+--- a/common/tools.py
++++ b/common/tools.py
+@@ -287,7 +287,7 @@
+                          %(path, str(e)), traceDepth = 1)
+     return os.path.isdir(path)
+ 
+-def mkdir(path, mode = 0o755):
++def mkdir(path, mode = 0o755, enforce_permissions = True):
+     """
+     Create directory ``path``.
+ 
+@@ -300,7 +300,8 @@
+     """
+     if os.path.isdir(path):
+         try:
+-            os.chmod(path, mode)
++            if enforce_permissions:
++                os.chmod(path, mode)
+         except:
+             return False
+         return True
diff -Nru backintime-1.2.1/debian/patches/series backintime-1.2.1/debian/patches/series
--- backintime-1.2.1/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ backintime-1.2.1/debian/patches/series	2021-05-31 15:14:50.000000000 +0200
@@ -0,0 +1 @@
+00-fix-946349.patch