On Thu, 2021-03-25 at 09:12 +0200, Andrius Merkys wrote: > On 2021-03-25 03:07, Mathias Gibbens wrote: > > On Wed, 2021-03-24 at 07:58 +0200, Andrius Merkys wrote: > > > 3. Upstream copyright entry in debian/copyright lacks years. If > > > the > > > upstream do not limit their copyright in years, I usually take > > > the > > > year > > > range spanning commits in the upstream Git repository (spotted in > > > openrct2-objects). > > > > OK, I've done as you suggest and looked at the git history to put > > some years in the d/copyright file. > > Looks good. Thanks! > > > > 4. In debian/rules of openrct2-title-sequences, there is a hard- > > > coded > > > upstream version of the package. This may easily get forgotten > > > when > > > packaging new upstream versions. I suggest replacing the hard- > > > coded > > > version with $(DEB_VERSION_UPSTREAM) from /usr/share/dpkg/pkg- > > > info.mk, > > > see [1] for example. > > > > That is indeed a nicer way to get the version. The upstream > > developers have released a few revisions of the current "version" > > that > > have a sequential letter appended, but the actual path for some of > > the > > files doesn't have that extra letter in it. I've updated the shell > > script so there's no longer a hard-coded value. > > I was about to suggest using sed to drop these sequential letters, > but I > see you already implemented this. > > > > You have indicated that you are going to be the sole maintainer > > > for > > > the > > > packages, which is OK. But have you considered team-maintaining > > > your > > > packages in Debian Games Team? Team maintenance has its > > > advantages, > > > for > > > example, team members would be able to commit and upload the > > > packages > > > fixing bugs and uploading new upstream versions. But of course > > > the > > > choice to team-maintain or not is yours. > > > > For now I'm planning to be the sole maintainer, but I'd be happy > > to > > eventually transition to a team setup as well. Beyond just getting > > openrct2 into Debian, I wanted to do all the work myself for the > > learning experience, and after going through the process of > > releasing > > updated versions as they become available once or twice, I'd be > > fine > > with bringing things under a team umbrella. > > Sounds reasonable. In the meantime you may join the Debian Games Team > if > you have not done that before. > > > > [1] https://sources.debian.org/src/byteman/4.0.12-2/debian/rules/ > > I uploaded new versions of all three packages to mentors.d.n, and > > pushed corresponding commits with the changes to the repositories: > > > > > > https://salsa.debian.org/gibmat/openrct2/-/commit/8bb65232c57b63c9ca18912772e4e78742a7cff7 > > > > https://salsa.debian.org/gibmat/openrct2-objects/-/commit/4e67cc2bac4b263c4a74c889923d2ba0e2f8effb > > > > https://salsa.debian.org/gibmat/openrct2-title-sequences/-/commit/8bbc6367390dd14e063fceb0a1346306eb30fdb5 > > > > If things are good, I believe the packages are ready. I've built > > them > > locally for my buster system, and everything that I've tested is > > working correctly. > > > > Also, once the packages are uploaded to NEW, I'll push a tag to > > each > > repository to properly record which commit corresponds to the > > uploaded > > version of each package. > > I have uploaded all three packages, and they have appeared in NEW. > Please push git tags for the commits you have mentioned (I use 'gbp > tag > --sign-tags'), and let's wait for ftpmaster's response. > > As said earlier, let me know should you need later sponsoring of > these > packages. > > Best, > Andrius > Thank you Andrius! I appreciate the time you've taken to sponsor my packages. I've pushed a signed tag to each repository. As new releases are made, or if there's any feedback from ftpmasters, I'll contact you directly. Mathias
Attachment:
signature.asc
Description: This is a digitally signed message part