Bug#985432: RFS: cornus/1.0.6-1 [ITP] -- fast file browser for Linux

[Lorenzo <plorenzo@disroot.org>]

On Thu, 18 Mar 2021 17:19:59 +0800
clay stan <claystan97@gmail.com> wrote:

> Package: sponsorship-requests
> Severity: wishlist
> 
> Dear mentors,

Hi!
 Disclaimer: I'm not a DD so I can't upload your package

This one I suspect could be a blocker:

* cornus_1.0.6.orig.tar.xz is different from the one provided by
  upstream. You are including the /debian directory while upstream is
  not. Keep the tar identical to the one provided upstream.

Other minor issues:

> 
> I am looking for a sponsor for my package "cornus":
> 
>  * Package name    : cornus
>    Version         : 1.0.6-1
>    Upstream Author : https://github.com/f35f22fan/Cornus/issues

 * you are confusing upstream name with issues

>  * URL             : https://github.com/f35f22fan/Cornus
>  * License         : GPL-3

* d/copyright: any parcticular reason why you are using Expat for your
  contributions while upstream code is under GPL-3? I think using the
  same license as upstream will make things easier

>  * Vcs             : https://salsa.debian.org/debian/cornus
>    Section         : utils
> 
> It builds those binary packages:

* d/control: your name is both in Maintainers and Uploaders field, you
  don't need both, keep the Maintainer.
* d/control: the extended description look odd to me, maybe someting
  like 
   "Cornus is a fast file browser written in C++17 and Qt5.
    It features a simple build-in text editor, easily customizable
    default app to open file types, graphic highlight of executable and
    extended attributes files, shortcut to delete files and a filesystem
    navigation sidebar."

Otherwise looks good to me
   
> 
>   cornus - fast file browser for Linux
> 
> To access further information about this package, please visit the
> following URL:
> 
>   https://mentors.debian.net/package/cornus/
> 
> Alternatively, one can download the package with dget using this
> command:
> 
>   dget -x
> https://mentors.debian.net/debian/pool/main/c/cornus/cornus_1.0.6-1.dsc
> 
> Changes for the initial release:
> 
>  cornus (1.0.6-1) experimental; urgency=medium
>  .
>    * Initial release (Closes: #984757)
> 
> Regards,

Regards,
Lorenzo