tag 975389 + moreinfo owner 975389 ! thanks Hi Dennis, Thanks for packaging dpf-plugins for Debian. Here is a review: Need fixing: d/changelog: 1. This is the initial release in Debian, so the the changelog should be empty except for the "Initial debian release (Closes: #953129)" entry. The earlier packaging work for KXStudio & Ubuntu is at least credited in d/copyright. d/copyright: 2. The distrho/extra plugins seem to be using the ISC license (not GPL2+), or at least that is the case for Thread.hpp. 3. dpf/distrho/extra/String.hpp has "Copyright (C) 2004-2008 René Nyffenegger", and Rene is not listed at all in d/copyright. 4. I stopped checking the d/copyright file here. I recommend a thorough check of d/copyright to ensure the package passes smoothly through the ftp-master review. Minor/optional stuff: 5. d/dpf-plugins-vst.lintian-overrides (and for the lv2, ladspa & dssi packages): "splitted" is not grammatically correct, and the lintian output should not be overriden, but a patch sent upstream. "3 Band Equalizer, split output version" would be better. 6. dpf-plugins-common emits a lintian warning about "no-manual-page" for the binaries. I tried a couple of them and they seem to open gui's and the normal -h & -v options do nothing. Maybe we could check the others and override the warning? Other comments: 7. I see version 1.4 is now available upstream. If you prefer, we could update to a full release rather than the "1.3 plus git commit" we have at the moment. I would be happy to upload with at least the first four comments fixed! Regards, Ross FBEE 0190 904F 1EA0 BA6A 300E 53FE 7BBD A689 10FC
Attachment:
signature.asc
Description: OpenPGP digital signature