Hi Paul, Version opentype-sanitizer_8.1.1+dfsg.1-1 uploaded to mentors. 2020-12-04 04:26 CET, Paul Wise: > On Thu, Dec 3, 2020 at 1:09 PM Romain Porte wrote: > > > Uploaded a new version +dfsg.1-1 on mentors with your explanation in > > debian/copyright as suggested by Lintian. > The URLs pointed to by the Vcs-* fields in debian/control do not > appear to exist. Repository created to reserve the name: https://salsa.debian.org/fonts-team/opentype-sanitizer I will however push after upload has been done to avoid to --force in case of any correction. > Please update the package to the new upstream release 8.1.1. Done. > Please fix the remaining minor lintian complaints where possible. Done, two warnings remain with `lintian -EviIL +pedantic`: * debian-watch-does-not-check-gpg-signature: uptream does not currently sign releases. I can create a issue on their bugtracker, but this should not impact first upload. * patch-not-forwarded-upstream: upstream is currently working on a fix to use system dependencies with a person from the Fedora project. While this is still in design process local patch will be kept. > Please remove the debmake template comments from debian/rules if you > aren't going to use them, although uncommenting the hardening one will > fix one lintian complaint. Done. > The debian/copyright file indicates that the debian/ directory is > licensed under the GNU GPLv3+. Usually it is recommended to use the > same license as upstream, so that upstream can easily adopt anything > that Debian includes in our package. This is especially important for > manual pages and patches. Good to know, done. > I suggest using wrap-and-sort with these arguments to make it easier > to read diffs of the debian/ directory. You seem to have already used > most of these. > > wrap-and-sort --short-indent --wrap-always --sort-binary-packages > --trailing-comma Done. > I note that the build process searches for freetype but the package > does not build-depend on it, is that intentional? This is intentional, to introduce the most used tool first for other packages to advance. Adding libfreetype2 will provide additional binaries which I do not intent to write man pages at the moment, as these tools are less used and not depended on by other packages. This can be fixed in a later 8.1.1+dfsg.1-2 release. > I note that the build uses a static library rather than a private > shared library for libots, which bloats the package slightly. No intent to change this at the moment, but it will probably be required as upstream python-ots package is compiling the project from scratch. Introducing a .so may help, but upstream is biased towards static linking so to be negociated. > Please forward the GCC warnings from the build log (or a patch fixing > them) to upstream. Done: https://github.com/khaledhosny/ots/issues/228 Did not patch because the resolution is not obvious. Best regards, Romain.
Attachment:
signature.asc
Description: PGP signature