Control: tags -1 moreinfo
On Fri, Oct 30, 2020 at 06:08:14AM -0400, Nick Black wrote:
> * Package name : notcurses
> Version : 2.0.2+dfsg.1-1
Hi Nick,
(Note I'm not planning to sponsor this package. I'm not a python packager, so I
can't judge on the python part.
[nitpicks] and [bikesheds] are marked…
Note that the review is not complete, especially I did not do a copyright review.
- d/changelog
The changelog entries for 1.7.6+dfsg.1-2 is different that the one in currently in the archives.
Please make sure that your packaging repository is in sync with the archives and matches it bit per bit.
See below for a (shortened) diff. [0]
- d/control
There are many versioned B-Ds. Please check if the version constraints can be dropped
(they can if oldstable has the version already) [nitpick]
It seems also that your CMakelists actually is only requiring cmake 3.14 -- is
the B-D version (> 3.16) is too strict [nitpick]
S-V is only 3 digits, the 4th digit is not recorded, as it only denotes editorial changes. [nitpick]
- the lintian overrides for "groff-message" are causing:
I: notcurses-bin: unused-override groff-message
- *.install: instead of usr/lib/*/, with compat 13, you should write
usr/lib/${DEB_HOST_MULTIARCH}/
- d/copyright, Files-Excluded
Yes, you can have multiline Files-Excluded, so you can wrap the wrong line.
(example at [1])
- *.install [bikeshed]
Not sure if TERMS.md, OTHERS.md and CONTRIBUTIONS.md should be installed into the library
package, as the information within is not really applicable for users of the library.
Does TERMS.md has a relation to notcurses or is it general information? If it relates,
maybe the -dev packge or a (see below) -doc package?
OTHERS.md, if installed, should go to the -dev package (but I think it is not useful,
as it just lists alternatives.)
The best place for CONTRIBUTIONS.md is the source package. I wouldn't install it in
binary packages.
- As you seem to have doxygen support, maybe generate html docs and have a dedicated
libnotcursed-doc package? [bikeshed]
I hope this review helps a bit. Thanks for your contributions to Debian!
--
tobi
[0]
--- /home/tobi/workspace/deb/mentors/NickBlack/notcurses/archive/notcurses-1.7.6+dfsg.1/debian/changelog
+++ /home/tobi/workspace/deb/mentors/NickBlack/notcurses/new/notcurses-2.0.2+dfsg.1/debian/changelog
@@ -1,9 +1,25 @@
(diff shortened)
notcurses (1.7.6+dfsg.1-2) unstable; urgency=medium
- [ Nick Black ]
- * Build in pbuilder to avoid picking up libav-extra, argh
-
- -- Nick Black <dankamongmen@gmail.com> Tue, 13 Oct 2020 18:41:52 -0400
+ * Actually update symbols for 1.7.6, ugh.
+
+ -- Nick Black <dankamongmen@gmail.com> Fri, 09 Oct 2020 22:04:50 -0400
notcurses (1.7.6+dfsg.1-1) unstable; urgency=medium
[1] https://tracker.debian.org/media/packages/d/dhewm3/copyright-1.5.1pregit20200905dfsg-1
Attachment:
signature.asc
Description: PGP signature