Bug#964308: RFS: geshi/1.0.9.1-1 [ITA] -- Generic Syntax Highlighter

[Nick Gasson <nick@nickg.me.uk>]

Hi Adrian,

Thanks for looking at this. I've uploaded a new version to
mentors.debian.net (#4):

https://mentors.debian.net/debian/pool/main/g/geshi/geshi_1.0.9.1-1.dsc

>
> -Build-Depends: cdbs, debhelper (>= 9)
> +Build-Depends: debhelper (>= 9), debhelper-compat (= 13)
>
> On the nitpick side is that debhelper-compat (= 13) is sufficient.

Done.

>
> Slightly more serious that you should document the switch from cdbs in 
> the changelog.
>

OK, I've added a changelog entry about this.

>>...
>> +  * debian/tests/test.php: add a simple sanity test.
>>...
>
> Is anything running this test?
> This looks like an autopkgtest without the control file.
>

No, I was just running it manually before. I've added a
debian/tests/control file and expected output so autopkgtest can run it.

>
> More a question is whether the Homepage in debian/control still points 
> to the best place. The current URL points to an outdated location.

I think http://qbnz.com/highlighter/ is still the best homepage, even
though it's outdated. The other option would be the GitHub project page
but that doesn't contain the documentation and examples which would be
more useful to end users. I asked on their GH Issues if the homepage
could be updated.

--
Thanks,
Nick