[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#965968: RFS: ipcalc-ng/0.4.1-2 -- parameter calculator for IPv4 and IPv6 addresses



Hello

On Wed, Jul 22, 2020 at 09:08:46PM -0300, Fabio Augusto De Muzio Tobich wrote:
Hi

Em 22/07/2020 18:38, gustavo panizzo escreveu:
Hi

On Wed, Jul 22, 2020 at 11:34:41PM +0200, gustavo panizzo wrote:
Hi


thanks for this package :)

I'm willing to sponsor this upload, but please add the wording change in
d/control to the changelog.


also please add that the wording on the patch
030_disable-few-tests.patch was changed

A suggestion (you don't need to do it) in the test `debian/tests/json` parse the output with jq or json_pp or
$other_tool to validate that the output is valid json

cheers!

Thanks for the help. :)
It's all done as you suggested, including the json validate.
But I had a problem uploading the package to mentors, the orig file is not "downloadable", the apache is
returning forbidden status.
Anyway, if you prefer, the salsa repo is updated: https://salsa.debian.org/debian/ipcalc-ng
I'll try to find a way to fix the situation on mentors.


I found this 3 lintian warnings

W: ipcalc-ng source: missing-license-paragraph-in-dep5-copyright gpl-2 (line 9)
W: ipcalc-ng source: missing-license-paragraph-in-dep5-copyright gpl-2+ (line 18)
I: ipcalc-ng source: unused-license-paragraph-in-dep5-copyright gpl-2 or gpl-2+ (line 36)

While GPL-2 and GPL-2+ license texts are similar, they are not the same.
You should add them both to the d/copyright file


the difference is this line
```
either version 2 of the License, or
(at your option) any later version.
```

Regards.


--
⢀⣴⠾⠻⢶⣦⠀ Fabio A. De Muzio Tobich
⣾⠁⢰⠒⠀⣿⡁ 9730 4066 E5AE FAC2 2683
⢿⡄⠘⠷⠚⠋⠀ D03D 4FB3 B4D3 7EF6 3B2E
⠈⠳⣄      GPG:    rsa4096/7EF63B2E

--
IRC: gfa
GPG: 0x27263FA42553615F904A7EBE2A40A2ECB8DAD8D5
OLD GPG: 0x44BB1BA79F6C6333


Reply to: