Bug#964928: RFS: dh-runit/2.9.0 [RC] -- debhelper add-on to handle runit runscripts

[Lorenzo Puliti <plorenzo@disroot.org>]

Package: sponsorship-requests
Severity: important

Dear mentors,

I am looking for a sponsor for my package "dh-runit"

 * Package name    : dh-runit
   Version         : 2.9.0
   Upstream Author : Dmitry Bogatov, Lorenzo Puliti
 * URL             : https://salsa.debian.org/debian/dh-runit
 * License         : GPL-3+
 * Vcs             : https://salsa.debian.org/debian/dh-runit
   Section         : admin

It builds those binary packages:

  dh-runit - debhelper add-on to handle runit runscripts
  runit-helper - dh-runit implementation detail

To access further information about this package, please visit the following URL:

  https://mentors.debian.net/package/dh-runit

Alternatively, one can download the package with dget using this command:

  dget -x https://mentors.debian.net/debian/pool/main/d/dh-runit/dh-runit_2.9.0.dsc

Updated git repository:
  
  https://salsa.debian.org/Lorenzo.ru.g-guest/dh-runit/-/tree/release-2.9.0

Changes since the last upload:

   * Add a comment on Conflicts and Breaks runit 2.1.2-36
   * Deprecate the 'since' option, bump depends on runit-helper
   * d/rules: clean testsuite artifacts
   * Disable the testsuite on armhf to workaroud FTBFS (Closes: #954190)
   * Acknowledge Helmut Grohne for fixing #939631
   * d/control: set Rules-Requires-Root: no
   * d/copyright: update copyright
   * Fix logservice failure due to loguser transition (Closes: #964175)
   * Avoid infinte loop of symlinks (Closes: #964174)
   * Print version in maintscript snippets
   * Do not overwrite the presubj file (Closes: #964178)


Some explanation that maybe can help people reviewing this package:

This is mainly a bugfix release:

[3f619215e51c8 ..]
The minor version bump is because the 'since' option is deprecated, I should have done that in
the 2.8.15 upload but I failed to realize that the patch for #942323 makes the since option useless.
With this commit when the option is used dh-runit does nothing but prints a warning.

[ed9cf32f1b9e ..]
the testsuite fails but only on armhf architecture. I think this is an issue in libghc-shake so
i'm disabling the tests on armhf for now.
I'm using the DEB_HOST_ARCH=armhf for this, i'm not sure if it's better to use the DEB_BUILD_ARCH instead

[6dedbf79ab4b86 ..]
runit uses the '_runit-log' user for logging a service stdout: previously was the 'runit-log' user.
This change in runit (2.1.2-36) breaks the appendant log service. Currently openssh-server and tor are
already affected by this, a few other services will suffer the same issue as they will be rebuild with
dh-runit in Sid.
this commit provides some transition code in 'runit-helper'; the code make sure to change the ownership
of 'lock' and 'current' files in the log directory

[cf9322698bc46f ..]
dh-runit has an option to ship a presubj file. It looks like if the package ships it's own presubj, 
this option overwrites the presubj file from the package with dh-runit presubj.
This commit turn the presubj option into a noop if there's already a presubj file and prints a warning.
It's possible to change this commit and make dh-runit append its presubj file content to the package 
presubj, but i'm not sure about the result (merging two presubj with potentially unrelated content, 
and the layout is of some concern too)


Regards,

--
  Lorenzo Puliti


-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.7.0-1-amd64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_FIRMWARE_WORKAROUND, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /bin/dash
Init: runit (via /run/runit.stopit)