[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#964113: RFS: materia-kde/20200614-1 [ITP] -- Port of the popular GTK theme Materia for Plasma 5



Hi Boyuan,

After reviewing the text of the copyright file, I had to reread the documentation to correct it, I understood that it was necessary to make a change and it was made in the commit 42145c86 to correct this file. The license check verified and returned that the files are under the GPL 3 license now, the upstream does the packaging only with this license for Ubuntu and distributes in the PPA of one of the collaborators. The verification did not include other licenses and is in line with the upstream. For this commit, the name must appear differently, but the author was me. I programmed it to be that way. Future commits of my own will be given under my name and that was reconfigured for this. The package updated at the mentors.debian.net.
I wrote this package from scratch and as much as I revised it, there were some errors that went unnoticed. The packaging is something that I've been practicing and studied a lot. References listed in the links I inserted in this email.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 3.0 (quilt)
Source: materia-kde
Binary: materia-kde
Architecture: all
Version: 20200614-1
Maintainer: Leandro Cunha <leandrocunha016@gmail.com>
Uploaders:  Boyuan Yang <byang@debian.org>,
Homepage: https://github.com/PapirusDevelopmentTeam/materia-kde
Standards-Version: 4.5.0
Vcs-Browser: https://salsa.debian.org/debian/materia-kde
Vcs-Git: https://salsa.debian.org/debian/materia-kde.git
Build-Depends: debhelper-compat (= 13)
Package-List:
 materia-kde deb kde optional arch=all
Checksums-Sha1:
 3cc777fa68890eb8c7f9930a8ed5a033c7502b83 855836 materia-kde_20200614.orig.tar.xz
 8a36b2d8829231cca69a201b7ecd9928095fc49e 1892 materia-kde_20200614-1.debian.tar.xz
Checksums-Sha256:
 189898b29c77ca7735c1b4ca47b702c1df0f7797d1ebca62411bfa7557749973 855836 materia-kde_20200614.orig.tar.xz
 3d6245c6de1088f962b2794910dc1cbcea924edc4732907e96ce8e64808581f9 1892 materia-kde_20200614-1.debian.tar.xz
Files:
 7eeda234996b92176ace15d83c796d51 855836 materia-kde_20200614.orig.tar.xz
 b0a4c77fb2fca50776b3cfb61da81b12 1892 materia-kde_20200614-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQHOBAEBCgA4FiEEdK8z89tH6D2icBWNcHfi0Y54OAMFAl8DxfwaHGxlYW5kcm9j
dW5oYTAxNkBnbWFpbC5jb20ACgkQcHfi0Y54OAP5rwv/VHQKWbSiyH/WXMhP9zef
SQ/8/o5aRo4zexuUeA1PucCbL7aTmVZz+AiEjqgLpaQJV+59JHZPuJmnOu3/ymhk
4VwEkRfBRAqJPivTTx+Rji8B9hNUjiTHKx3PvusD34Hz5kP4q/1+J3DbhBrdkK2m
tKYHmJiyRzenFFq0ko1ZlSyTsPnnSSsEXMakHh6AQEo5afCglZVbvF0TjTwnqVl3
PM/YqKRIciwqKQBN26TnyzrSDvsJWDPyX7CJ9KZ6CHA1YwzqQxTbcthny4772yvv
PtENZJVSrcOY61QQMucYyMkqp4FhUCOJg/oeuoEfcWxVZC68hJw/XDr6dduSWqBs
xmyN6MQ7GZ9b79SbBI85PAZyhx42/KbIL9eysY/SHK0GhvtLmUR3TbH36hNus+Ef
vgWSbV26VNiR35xv+HqgfOKZ9YQJxAl/jDJ/tsNhbY8m0CCW8QsrcO1I0Dx/bAiC
XonbUxAIziLj9K4sCMNcLJ05fI5bfbJ1TRv3uEe0gNVi
=71WS
-----END PGP SIGNATURE-----

[0] https://store.kde.org/p/1229144/
[1] https://salsa.debian.org/debian/materia-kde/-/commit/d96b30254b8ae950379ff64b42679243f78d174e
[2] https://github.com/PapirusDevelopmentTeam/materia-kde
[3] https://mentors.debian.net/package/materia-kde
[4] https://mentors.debian.net/debian/pool/main/m/materia-kde/
[5] https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
[6] https://www.debian.org/doc/manuals/developers-reference/
[7] https://wiki.debian.org/CopyrightReviewTools
[8] https://wiki.debian.org/Packaging
[9] https://www.debian.org/doc/manuals/packaging-tutorial/packaging-tutorial.en.pdf
[10] https://github.com/PapirusDevelopmentTeam/materia-kde/tree/packaging

Regards,

Leandro Cunha


Em dom., 5 de jul. de 2020 às 18:47, Boyuan Yang <byang@debian.org> escreveu:
Hi Leandro,

在 2020-07-01星期三的 22:57 -0300,Leandro Cunha写道:
> Dear mentors,
>
> The code is in my Salsa repository until the creation of the
> mentioned VCS and I am not allowed to access the project file. After
> that, the work will be centered on the informed VCS.
>
> [0] https://salsa.debian.org/leandrocunha/materia-kde

I have imported your project into salsa.debian.org/debian/materia-kde.
Please use this new repo for future packaging.

After review, there are several issues that need to be fixed before we
proceed. I fixed several issues (as well added me as the uploader) in
https://salsa.debian.org/debian/materia-kde/-/commit/42145c86d8ac221353ee5c439b3dce15f25928c5
 and you may review the changes here. Besides, I reimported the
upstream source code to guarantee that we are using exactly the same
source code as upstream tagged in the GitHub repository. You may find
corresponding changes in the upstream/latest branch.

There is one serious issue left that cannot be fixed by myself: in
debian/copyright file, you listed that the files are licensed under
GPL-3. In the license  text, you wrote that the files are licensed
under "GPL version 3 or any later version", which contradicts with each
other. Since the LICENSE only contains the license of GPL-3, I have no
idea whether the whole project is under GPL-3 or GPL-3+. Please contact
the upstream and clarify the license condition. Ideally please provide
such clarification in upstream README.md file.

Please feel free to let me know if you have any questions regarding my
changes. Let me know after the licensing issue is solved so that the
package can be uploaded.

--
Regards,
Boyuan Yang

Reply to: