Bug#962091: RFS: xine-ui/0.99.12-1 [QA] -- xine video player, user interface
Hi, and thanks for the review.
lør. 6. jun. 2020 kl. 11:41 skrev Adrian Bunk <bunk@debian.org>:
>
> Control: tags -1 moreinfo
>
> On Wed, Jun 03, 2020 at 08:04:45AM +0000, Håvard Flaget Aasen wrote:
> >...
> > Changes since the last upload:
> >...
> > * d/rules
> > - Change to dh-sequence
> >...
> > * d/control
> >...
> > - Remove unnecessary Depends field
> >...
>
> This was necessary, it was just broken by your debian/rules rewrite.
> This RC regression can easily be reproduced with aaxine.
>
> For the debian/rules change, please verify that the changed package
> does not contain any unexpected changes from the original one.
> This means first understanding what the old debian/rules did.
> I can immediately find two things that were done in the old debian/rules
> but are missing in the new one.
>
I re added the dependency fields in d/control, dh_xine, and
dh_compress targets in d/rules, which shouldn't have been removed,
thanks for spotting that. I also added back dh_installchangelog,
I'm still not sure if anything is actually using this symlink, but it
is consistent with the previous version.
> > * Add fix_spelling_error.patch
> >...
I've updated the .pot file and .po files as well, I believe that should fix it.
>
> This is a translated string, such a change breaks all translations of
> this string.
>
> > Regards,
> > Håvard
>
> cu
> Adrian
Regards,
Håvard
Reply to: