Bug#956965: RFS: sipxtapi/3.3.0~test18+dfsg.1-1.1 [NMU] -- SIP stack, RTP media framework and codecs
Control: tags -1 moreinfo
Hi Sudip,
thanks for the updated package!
Some remarks:
The only thing that really needs fixing is that:
- the version should be 3.3.0~test18+dfsg.1-0.1 (NMUing upstream versions have
debian revision 0)
The rest are minor things, but it would be nice if you could fix them as well:
- There is prebuilt doxygen documentation in sipXcallLib/doc/sipXtapi/html/
As you anyway repacking, please remove them as well.
- There are a lot of unwanted files un sipXcallLib/examples. Like pcre.a *.lib
files or a ton of 3rd party library headers (wx, nss)
As the examples are not installed anyway, I think it is ok just to strip them
from the source and tweak the build system not looking for them.
(I did a quick test by deleting the folder and tweaking configure.ac and
sipXcallLib/Makefile.am and it builds at least. patch attached.)
As a side benefit, this will also fix some linitan stuff ;-)
- please add a "s" to fix:
P: sipxtapi source: insecure-copyright-format-uri
http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Also easy to fix:
I: sipxtapi source: unused-file-paragraph-in-dep5-copyright paragraph at line 37
I: sipxtapi source: unused-override license-problem-non-free-RFC
sipXportLib/src/hmac-sha1/sha1.c
I: sipxtapi source: unused-override license-problem-non-free-RFC
sipXportLib/src/hmac-sha1/sha1.h
I: sipxtapi source: wildcard-matches-nothing-in-dep5-copyright
sipXtackLib/include/*.c (paragraph at line 37)
--
Cheers,
tobi
--- sipxtapi-3.3.0~test18+dfsg.1/configure.ac 2020-04-17 17:39:04.724141006 +0200
+++ sipxtapi-3.3.0~test18+dfsg.1_/configure.ac 2020-04-17 17:38:18.183321746 +0200
@@ -189,8 +189,6 @@
bin/Makefile
sipXcallLib/Makefile
sipXcallLib/doc/Makefile
- sipXcallLib/examples/Makefile
- sipXcallLib/examples/sipXezPhone/Makefile
sipXcallLib/include/Makefile
sipXcallLib/src/Makefile
sipXcallLib/src/test/Makefile
--- sipxtapi-3.3.0~test18+dfsg.1/sipXcallLib/Makefile.am 2020-04-17 17:39:04.724141006 +0200
+++ sipxtapi-3.3.0~test18+dfsg.1_/sipXcallLib/Makefile.am 2020-04-17 17:38:18.187322097 +0200
@@ -9,7 +9,7 @@
config/sipXcommon.am.inc \
CONTRIBUTORS
-unconditional_SUBDIRS = . src examples include
+unconditional_SUBDIRS = . src include
# bin is not really needed now that we have a top-level build system
#unconditional_SUBDIRS += bin
Reply to: