Bug#930274: RFS: junitparser/1.3.2-1 [ITP]
On 6/29/19 10:28 AM, Bastian Germann wrote:
> Hi Herbert,
>
> Thanks for coming back to me. I uploaded a new version with the
> suggested changes.
>
>> # lintian-info -t 'tag'
>>
>> - upstream-metadata-file-is-missing
>>
>> It is pedantic. There are info here to fix that:
>> Refer to https://dep-team.pages.debian.net/deps/dep12/ and
>> https://wiki.debian.org/UpstreamMetadata for details.
>
> I have included a metadata file.
Thanks for that.
>
>> - debian-watch-does-not-check-gpg-signature
>>
>> There is gpg signature. Ignore.
>>
>> - library-package-name-for-application usr/bin/junitparser
>> application-in-library-section python usr/bin/junitparser
>>
>> Junitparser README.rst file shows how to use it as a module and
>> by command line. The command 'tree debian/python3-junitparser'
>> shows the module and the command line script. The manpage is
>> the README.rst file.
>>
>> Please split the package (one depends on other):
>>
>> - python3-junitparser is the module
>> - junitparser is the 'utils' (in Section)
>>
>> The README.rst file. The command line part can be the manpage.
>> The rest can be a documentation in '/usr/share'
>
> Okay. I have included the README.rst in python3-junitparser and moved
> the binary and its edited manpage to the package junitparser.
Ok.
>
>> The package does not build twice because junitparser.egg-info dir
>> is not removed between builds. Please override dh_clean to do that.
>
> I used the debian/clean file for that.
Good!
>
>> There is no 'debian/tests/control' file. No CI. Please see to how
>> run upstream tests by autopkgtest.
>>
>> https://ci.debian.net/
>
> I already had a "Testsuite: autopkgtest-pkg-python" line in d/control. I
> guess this is also picked up by ci.debian.net. If not, what should I put
> into debian/tests/control to run the same tests there?
Using d/tests/control we can run the upstream tests too. Not only
a import module test.
The result:
[...]
----------------------------------------------------------------------
Ran 59 tests in 0.040s
OK
[...]
autopkgtest [14:50:55]: test autodep8-python3: set -e ; for py in $(py3versions -r 2>/dev/null) ; do cd "$AUTOPKGTEST_TMP" ; echo "Testing with $py:" ; $py -c "import junitparser; print(junitparser)" ; done
autopkgtest [14:50:55]: test autodep8-python3: [-----------------------
Testing with python3.7:
<module 'junitparser' from '/usr/lib/python3/dist-packages/junitparser/__init__.py'>
autopkgtest [14:50:56]: test autodep8-python3: -----------------------]
autopkgtest [14:50:56]: test autodep8-python3: - - - - - - - - - - results - - - - - - - - - -
autodep8-python3 PASS (superficial)
autopkgtest [14:50:56]: @@@@@@@@@@@@@@@@@@@@ summary
command1 PASS
autodep8-python3 PASS (superficial)
debian/tests/control file:
Test-Command: python3.7 -m unittest discover -v
Restrictions: allow-stderr
Depends: @
Regards,
Herbert
Reply to: