Bug#925911: RFS: lopsub-1.0.2 [ITP]
On Thu, Mar 28, 2019 at 11:41:45AM +0100, Andre Noll wrote:
> * Package name : lopsub
> Version : 1.0.2
Such a version means a native package; only software written specifically
for Debian which makes no sense outside it should use the native format.
Even if you're both upstream and the packager, a non-native format is
helpful in case someone other than you would upload a fix.
This library is certainly not something for Debian only, thus please append
"-1" to the version, and set debian/source/format to "3.0 (quilt)" (which,
despite the name, doesn't require actually using quilt).
> Upstream Author : Andre Noll <maan@tuebingen.mpg.de>
> * URL : http://people.tuebingen.mpg.de/maan/lopsub/
> * License : (L)GPLv3
It would be nice to mention more prominently what parts are GPLv3-ed and
which are LGPLv3-ed.
> Section : libdevel
>
> lopsup - The Long Option Parser for Subcommands
> However, there are still some warnings from lintian
> I don't know how to deal with.
I'd recommend running "lintian -i" which gives a long descriptive message
for every warning, including hints how to fix.
I see a static library installed by the package. Those shouldn't generally
be used unless you're doing something special -- static linking makes
security and bugfix updates extremely tedious. Libraries should also be
split into separate binary packages, with lib${name}dev providing
development files while lib${name}${so} the runtime lib.
I'll stop this round of review here; I haven't took a look at the actual
functionality yet.
Meow!
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Did ya know that typing "test -j8" instead of "ctest -j8"
⢿⡄⠘⠷⠚⠋⠀ will make your testsuite pass much faster, and fix bugs?
⠈⠳⣄⠀⠀⠀⠀
Reply to: