Bug#910608: RFS: libtheft/0.4.5-1 ITP #910296
On Sun, 21 Oct 2018, at 06:50, Gergely Nagy wrote:
> Hi!
>
> I just had a quick look at the libtheft packaging on mentors, and
> noticed a few things that at the moment, prevent me from sponsoring the
> package. These are:
Hi! thanks for reviewing this!
>
> - I was unable to find the public part of your GPG key, thus, was unable
> to verify the signature on the source package. Where can one find it?
GPG key has now been uploaded to default keyservers, key id is 3D3239533DAE7F5A9D322B7C52322452F1C90E1E
> (Uploading it to a public key server might be best).
> - The package build-depends on `debhelper-compat (= 11)`, which works,
> but it's a virtual package. I'd suggest build-depending on `debhelper
> (>= 11)`, and adding a `debian/compat` file with "11" as its content.
skipping as discussed
> This will get rid of one of the warnings on mentors, too.
> - debian/copyright does not document the license of `src/theft_hash.c`
> (public domain, but that needs to be documented too).
fixed
> - debian/copyright does not document the license and author of
> `debian/*`. In most cases - and theft is no exception - the Debian
> packager is not the upstream author. If unspecified, the `*` wildcard
> applies to `debian/*` too, which would be incorrect.
fixed
> - The control file does not set a Homepage - a minor thing, but while
> fixing the other issues, might as well fix this one, and point the
> Homepage field in debian/control to theft's GitHub.
fixed
>
> Other than these, the package looks ok. Can you fix the above?
>
> Drop me an email when done, and I'll have another look.
Fixed remaining issues, sorry this took me a while to get to.
I have uploaded a new version of the package to mentors.
Reply to: