Bug#896970: RFS: odp/1.19.0.0-1 [ITP]
- To: Lumin <cdluminate@gmail.com>
- Cc: Debian Bug Tracking System <896970@bugs.debian.org>
- Subject: Bug#896970: RFS: odp/1.19.0.0-1 [ITP]
- From: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
- Date: Fri, 31 Aug 2018 15:41:01 +0300
- Message-id: <[🔎] CALT56yMxb5TJHN8x5-n310RaE7C9+FWUWb-gSLaGGrk+=dwNQw@mail.gmail.com>
- Reply-to: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>, 896970@bugs.debian.org
- In-reply-to: <20180602040841.GC21013@Asuna>
- References: <152474542013.1638.14370939072603460024.reportbug@rhovanion.lumag.spb.ru> <152491310669.11548.6373633568067491441.reportbug@rhovanion.lumag.spb.ru> <20180505134735.GA32133@Lea> <CALT56yMEbg79petmpmD7ct9WzAFuNBBbQE-H+1bNx=HgA0-t0Q@mail.gmail.com> <CALT56yNoJ_StCZTPC9juGXbPTMrsOreAUmF0aactCk6H_TfX8A@mail.gmail.com> <20180525063123.GA24903@Asuna> <CALT56yPsqCJ0j1MS=Pg4h16b-Zto2Dnz=0_tF50GNGbhmQO1nw@mail.gmail.com> <20180602032407.GA21013@Asuna> <20180602040841.GC21013@Asuna> <152474542013.1638.14370939072603460024.reportbug@rhovanion.lumag.spb.ru>
Hello,
I've uploaded new 1.19.0.2-1 version to mentors.d.o.
I've added manpages, fixed copyright info, fixed alternatives
and enabled auto-tests. Could you please review it?
сб, 2 июн. 2018 г. в 7:08, Lumin <cdluminate@gmail.com>:
>
> On Sat, Jun 02, 2018 at 03:24:07AM +0000, Lumin wrote:
> > Please fix the aforementioned problems. Hopefully we'll have the last
> > round of check next time. Thank you for working on this.
> >
> > [1] http://debomatic-amd64.debian.net/distribution#unstable/odp/1.19.0.1-1/buildlog
>
> Forgot to check the copyright ... The copyright looks incomplete. A
> simple search on the source tree would reveal many non-Linaro copyright
> holders:
>
> grep -ri copyright | grep -vi linaro | grep -i copyright
>
> The package will be rejected by ftp-master if we don't fix the
> copyright.
Should be fixed now.
>
> When checking odp-dpdk, one more problem was found:
>
> root@b69fed1c16e0 ~/odp-dpdk-1.19.0.0# update-alternatives --config libodp-linux.so-x86_64-linux-gnu
> There are 2 choices for the alternative libodp-linux.so-x86_64-linux-gnu (providing /usr/lib/x86_64-linux-gnu/libodp-linux.so).
>
> Selection Path Priority Status
> ------------------------------------------------------------
> * 0 /usr/lib/x86_64-linux-gnu/odp-generic/libodp-linux.so 40 auto mode
> 1 /usr/lib/x86_64-linux-gnu/odp-dpdk/libodp-linux.so 40 manual mode
> 2 /usr/lib/x86_64-linux-gnu/odp-generic/libodp-linux.so 40 manual mode
>
>
> * 0 /usr/lib/x86_64-linux-gnu/odp-dpdk/libodp-linux.so.119 60 auto mode
> 1 /usr/lib/x86_64-linux-gnu/odp-dpdk/libodp-linux.so.119 60 manual mode
> 2 /usr/lib/x86_64-linux-gnu/odp-generic/libodp-linux.so.119 40 manual mode
>
> Taking BLAS as an example, the generic and slow libblas3 provides
> libblas.so.3 symlink with a priority of 10. Faster implementations
> provides the same symlink with higher priorities, e.g. 40 for openblas.
>
> Maybe you want to adjust the priority values in those postinst scripts?
> The exact value is up to you, as long as it helps to tell the difference
> among different implementations.
I'll fix odp-dpdk later.
--
With best wishes
Dmitry
Reply to: