Bug#905053: RFS: trojan/1.5.1-1 [ITP]
Hi GreaterFire,
Thank you for the package. I'm not sponsoring this package but I have
some comments about it. You can feel free to omit the comments tagged
"recommended".
1. Why is dh_auto_test noopped?
The following tests FAILED:
1 - LinuxSmokeTest-basic (Failed)
As the software upstream, you should try to fix the bug instead of
ignoring it.
2. [Recommended] It would be better if there are Vcs-Browser and Vcs-Git
fields in the control file.
3. [Recommended] testsuite-autopkgtest-missing. A set of sensible test
scripts would speed up its migration into testing.
http://packaging.ubuntu.com/html/auto-pkg-test.html
4. package-does-not-install-examples .
There are several example files under the source tree. Please install
them so that the user can find them after installation.
1. create a file debian/examples
2. put this line in the file
```
examples/*
```
Well, the copyright file looks good to me. Please fix the issues
mentioned above, and do lintian check if you think it's ready for the
next round of review.
```
lintian -EviI --pedantic xxx.changes
```
Feel free to ask if you encounter problem.
Reply to: