Bug#904745: RFS: mint-y-icons/1.3.0-1 [ITP]

[Adam Borowski <kilobyte@angband.pl>]

On Fri, Jul 27, 2018 at 03:04:04PM +0200, pavel-rehak@email.cz wrote:
> * Package name    : mint-y-icons
>   Version         : 1.3.0-1
> * URL             : https://github.com/linuxmint/mint-y-icons
> * License         : GPL-3+, CC-BY-SA-4.0

> * Package name    : mint-y-theme
>   Version         : 1.2.3-1
>   Upstream Author : Clement Lefebvre  root@linuxmint.com
> * URL             : https://github.com/linuxmint/mint-y-theme

> To access further information about this package, please visit the following URL:
> 
> https://mentors.debian.net/package/mint-y-icons

Hi!
I've done only a very cursory review so far, and I see:

* menu bar in GTK3 programs is squashed, here's a screenshot:
  https://angband.pl/tmp/mint-y-menu.png
  GTK2 programs are ok, so are QT (QT uses GTK2 theme, I think it can be
  configured for GTK3 these days though)

* both in -theme and -icons, you ship pre-built files, and don't even delete
  them during build.  That makes it hard to ensure that what you install is
  indeed built from provided source.

  It would be best to repack the .orig tarballs to remove usr/ dirs inside
  -- besides making things unclear, they also waste space, and might
  possibly include parts that don't have source.

* the copyright files in both -theme and -icons need to include all authors
  (you can often get away with naming a group, though).  They don't even
  list files in debian/ (the packaging).  In -theme, the README.md says it
  is based on Arc.  In -icons, there's a long list of themes some categories
  of icons have been copied from.  Those authors need to be mentioned. 

  There's a disagreement on how detailed the list should be: some people
  want everything to be accurate down every file, others say something like:
  Files: *    Copyright: 1991-2012 Linus Torvalds and many others
  You need to do it detailed enough to pass ftpmasters' review, and their
  minimal requirements tend to be somehwere in the middle.  And here, you
  didn't list most authors at all, even as part of a group.


Meow!

(.sig related -- but no matter how _I_ feel about copyright, with a DD hat
on I still need to respect it, as it's not up to me to decide)
-- 
// If you believe in so-called "intellectual property", please immediately
// cease using counterfeit alphabets.  Instead, contact the nearest temple
// of Amon, whose priests will provide you with scribal services for all
// your writing needs, for Reasonable And Non-Discriminatory prices.