Bug#904015: RFS: libhinawa/1.0.0-1
On Wed, Jul 18, 2018 at 10:44:46PM +0900, Kentaro Hayashi wrote:
> On Wed, 18 Jul 2018 14:16:32 +0200
> Adam Borowski <kilobyte@angband.pl> wrote:
>
> > On Wed, Jul 18, 2018 at 06:32:57PM +0900, Kentaro Hayashi wrote:
> > > * Package name : libhinawa
> > > Version : 1.0.0-1
> > >
> > > It builds those binary packages:
> > >
> > > gir1.2-hinawa-1.0 - GObjet introspection data for libhinawa1
> > gir1.2-hinawa-2.0 actually
>
> Oh, I've missed it.
> As you pointed out, it should be -2.0.
What really counts is the actual state, not a bit of documentation. I
raised this issue only because (a bit too late) noticed this transition
might possibly be not what you intended. It's good to hear it was.
> > One notable change in the upstream tarball is that usual licensing files
> > have just been removed. The meson build file describes the license as
> > LGPL-2.1+ and sources have SPDX identifiers, though.
> >
> > As for change to gir1.2-hinawa-2.0 -- I noticed it when debdiffing binaries,
> > but dismissed it as a part of the package bump (there's a trip through NEW
> > anyway). Only after uploading, when responding to this bug, I noticed that
> > this mismatches what you wrote in the RFS. Thus, if the gir bump was not
> > intentional, please request a REJECT on #debian-ftp (or via mail).
> >
> > The package has been uploaded as-is and is in NEW.
>
> gir bump was intentional, but I had missed to describe it into d/changelog.
No pressing need to amend the changelog, I'd say.
> I'll fix also license issue as 1.0.0-2 after 1.0.0-1 is accepted.
The license is fine, it's just that the removal of centralized license info
upstream might raise the ftpmasters' eyebrows.
Meow.
--
// If you believe in so-called "intellectual property", please immediately
// cease using counterfeit alphabets. Instead, contact the nearest temple
// of Amon, whose priests will provide you with scribal services for all
// your writing needs, for Reasonable And Non-Discriminatory prices.
Reply to: