在 2018年7月8日星期日 CST 下午3:21:42，Daiki Ueno 写道： > Hello Boyuan, > > Boyuan Yang <073plan@gmail.com> writes: > > libskk (1.0.4-1) unstable; urgency=medium > > . > > > > * Team upload. > > * New upstream release. (2018-06-26) > > * Bump Standards-Version to 4.1.5. (no changes needed) > > * debian/patches: Refresh patches and backported patches. > > Thank you for packaging. I have a couple of suggestions. > > First, the package seems to include the patches from an unmerged PR: > https://github.com/ueno/libskk/pull/54. > > I generally don't recommend backporting patches not merged into master, > because there is usually a reason to keep them unmerged. Of course, you > can pick any patch as you want; in that case, it would be appreciated if > you give a code review on the PR :-) Hi Daiki, Thanks for the hint. I reviewed the packaging procedure again and found that I accidentically treated your WIP branch as the master branch. Sorry for that and I will review the code base in case any regression lies inside. > Secondly, you can remove myself from uploaders as I am no longer a DM[1]. > The same applies to the other few packages[2]. Thanks, I will help to handle them. > Footnotes: > [1] https://wiki.debian.org/DebianMaintainer#Debian_Maintainer_retirement > > [2] https://qa.debian.org/developer.php?email=ueno%40unixuser.org > > Regards, -- Regards, Boyuan Yang
Attachment:
signature.asc
Description: This is a digitally signed message part.