On Tuesday, April 24 2018, Fabian Wolff wrote:
> On Mon, Apr 23, 2018 at 08:58:30PM -0400, Sergio Durigan Junior wrote:
>> Hi Fabian,
>>
>> I can help with it, but there are two things I'd like to see first.
>
> Thank you for your review!
My pleasure. Thanks for the work on the package!
>> 1) There are no Vcs-* fields, and it's unclear to me where the git
>> repository for the package is located (I couldn't find it on
>> salsa.d.o).
>
> I did not maintain the package in a public Git repository so far, so I
> created a fresh repository, imported my changes and put it on Salsa:
>
> https://salsa.debian.org/wolff-guest/python-picklable-itertools
>
> I have added Vcs-Git and Vcs-Browser fields accordingly.
Thanks, much appreciated. I can also create a repository under the
Debian namespace on salsa if you want.
Or you can also move the package under the Debian Python Modules Team
umbrella, if it makes more sense. Packaging Python modules with the
DPMT is the preferred way nowadays, but that's really up to you (and
just to be clear, I have no problem if you decide to maintain the
package by yourself).
>> 2) If having the Python 2 version of this package is important for some
>> reason, could you please override the lintian warning
>> ("new-package-should-not-package-python2-module")?
>
> I think that the Python 2 version is not really important; in fact, I
> did not even include it in the original package, but my previous
> sponsor for this package suggested that I should add it (see #841228).
Oh, well. I don't want to go against Gianfranco here :-). I understand
his reasoning, and actually there's a very recent thread developing on
debian-devel about this exact topic; see:
<https://lists.debian.org/debian-devel/2018/04/msg00508.html>
> I have now simply removed the Python 2 package from debian/control; is
> this sufficient, or do I have to do anything more than that?
I think it's best if we keep the package unchanged for now. Sorry about
this extra round-trip, but can you please re-add the Python 2 package?
Actually, I've just noticed that the lintian flag in question
("new-package-should-not-package-python2-module") only applies to the
first upload of the package, and will actually be gone once we upload
this next version, so there's really nothing that needs to be done from
your part about it. I'm sorry about the noise.
Once you reintroduce the Python 2 package, I'll do the upload.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
Attachment:
signature.asc
Description: PGP signature