Bug#889515: <DKIM> Re: <DKIM> Re: Review of persepolis
I really appreciate your and your AM's review. I fixed all the mentioned issues.
The Vcs-* fields are now pointing to a repository on Salsa. It is
based on a guest username for now. As soon as someone sponsors the
package (hopefully you do :) ), a repository can be created in debian
group with write access granted to me, so it will look like:
https://salsa.debian.org/debian/persepolis
I keep my fingers crossed for your application and I hope it gets
accepted as soon as possible. You are a really helpful person :)
On Mon, Mar 5, 2018 at 9:18 PM, Julien Puydt <julien.puydt@laposte.net> wrote:
> My AM reviewed your package and found two things :
>
> - in d/control, the line X-Python3-Version is useless (stable has that
> already!) -- easy to fix, wouldn't get the package rejected ;
>
> - in d/copyright, "Check the website for the full list." would get the
> package rejected : either put the full list, or leave the one name you
> already have (and is the one given in setup.py)
>
> Afterwards I saw other problems:
>
> - in d/control, your Vcs-* fields should point to where the packaging is
> managed, not to upstream. If you don't maintain in a publically
> available repository, those fields should probably not be there ; see:
> https://www.debian.org/doc/manuals/developers-reference/ch06.html#bpp-vcs
> and
> https://www.debian.org/doc/debian-policy/#version-control-system-vcs-fields
>
> - in d/control, I wonder if using "GUI" repeatedly in the description is
> a good idea ; what about something like this, with different paragraphs
> for different ideas :
>
> Description: Graphical download manager based on Aria2
> Persepolis is a graphical user interface on the Aria2 download manager.
> .
> Aria2 is a high speed download utility which is capable of making several
> connections to download files. It will boost the download in some cases,
> specially if you have a limited connection.
> .
> Persepolis makes the usage of Aria2 easier by providing a graphical
> interface for it and in
> addition, it includes some extra functionalities like scheduled downloads.
>
> With some luck I'll be a DD soon and sponsor you myself :-)
Reply to: