Bug#888526: RFS: dxf2gcode/20170925-5 [ITP] -- converts 2D drawings to G-code for CNC machines
On 02/01/2018 11:13 AM, Juhani Numminen wrote:
Control: tags -1 moreinfo
Sebastian Kuzminsky kirjoitti 26.01.2018 klo 20:15:
Dear Mentors/Sponsors,
I am looking for a Sponsor for my package "dxf2gcode":
Here's my short review of the package, but I can't sponsor it.
Thank you very much for this feedback.
I'm afraid the package cannot be built twice in a row (build log attached),
which indicates that the clean target is not functioning as it should.
(The relevant Debian Policy chapter is 4.9.)
One way to make the cleaning adequate is in build_twice.diff.
I added a patch to disable the pylupdate part because it is modifying
the *.ts files which is a bit problematic from our POV. If you go that
route, I suggest asking upstream to provide a way to disable pylupdate,
in order to keep Debian-specific changes to a minimum.
I've applied your patch, with the make_tr change modified to hopefully
be more palatable to upstream.
Repeated builds succeed now.
Have you forwarded 0001-install-AppStream-metadata-in-the-correct-directory.patch
upstream? Please also use DEP3 to document it in the patch file.
http://dep.debian.net/deps/dep3/
I added DEP3 tags to the appstream patch and to the modified version of
you make_tr patch, and submitted them upstream:
https://groups.google.com/forum/#!topic/dxf2gcode-dev/vKUTXa9EgjQ
You have build-depends qt4-linguist-tools, which seems to work, but Qt5
linguist tools are in qttools5-dev-tools as indicated by this search:
https://packages.debian.org/file:lrelease
Oops! Fixed.
I uploaded a new version of the package that I believe addresses all
your review comments:
https://mentors.debian.net/package/dxf2gcode
When you have resolved these, you can remove the moreinfo tag from the RFS.
Will do!
--
Sebastian Kuzminsky
Reply to: