Em qua, 2017-10-25 às 21:28 +0200, Tobias Frost escreveu: > Thanks for the updated package. > Please note that I've edited the bug title because this is not an QA upload > but a regular one. Thank you for your attention. :) I had a small bug in the previous version that is in Debian, which was able to correct in this version. I made some simple improvements. > Can you also check #86227 if it is valid? > (But then please recreate the png at build time) [1] Sorry, but I do not know this bug number #86227 [2] I had a bug in the desktop file that contained format (xpm) in the icon line. That was corrected. > Regarding the script, I see you have a hardcoded temporary path in it. > When ~/.rs-temp exists for whatever reason, you wil nuke user data. That needs > to be fixed... (I will file a bug to document this later) This is a temporary directory where it will decompress a format file (dmg), and move a format file (jar) and then exclude this temporary directory. [3] It is now commented out in the installation script. > Please reupload and ping me when ready. Forgive me, but I did not understand this last sentence. :( Thanks! --- [1] - https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=86227 [2] - https://github.com/coringao/runescape/commit/fa27aa61ea52cc7cc8b7624f9ece7 e4fddacb3ef [3] - https://github.com/coringao/runescape/blob/master/src/runescape.sh -- ⢀⣴⠾⠻⢶⣦⠀ Carlos Donizete Froes [a.k.a coringao] ⣾⠁⢠⠒⠀⣿⡁ - https://wiki.debian.org/coringao ⢿⡄⠘⠷⠚⠋⠀ GPG: 4096R/B638B780 ⠈⠳⣄⠀⠀⠀ 2157 630B D441 A775 BEFF D35F FA63 ADA6 B638 B780
Attachment:
signature.asc
Description: This is a digitally signed message part