Bug#876667: RFS: pragha/1.3.3-1
Hi Gabriel,
thanks for improving upon our suggestions.
On Sun, 24 Sep 2017 15:15:41 -0300
"Gabriel F. T. Gomes" <gabriel@inconstante.eti.br> wrote:
> Lukas,
> In that same message [1], you suggested the use of a version control
> system, but I don't know where to make it public (I know that alioth
> is being discontinued, so I'm a bit lost with this).
I hope someone here will have a suggestion where your repository can
live.
> I think I solved all other problems you pointed out.
Looks like it. I just took another look and saw a few more minor
things:
* The upstream tarball you uploaded to mentors is not exactly the same
one as on github:
$ cmp pragha-1.3.3.tar.gz pragha_1.3.3.orig.tar.gz
pragha-1.3.3.tar.gz pragha_1.3.3.orig.tar.gz differ: byte 5, line 1
If you use git and git-buildpackage, make sure to use the
"pristine-tar" feature. When using this, a small delta file will be
added to a special pristine-tar branch. This allows to reconstruct
the original tarball exactly as it was.
* In the debian/watch file you should replace "<project>" with
"pragha" (it also works as is, but then the downloaded tarball is
called "<project>-1.3.3.tar.gz" before the symlink is created).
* in debian/patches/fix-appstream-errors.patch:
- referencing the ITP bug here does not make sense; you should only
use "Bug-Debian" if there is a bug in the Debian BTS that is
related to the patch (for example, if someone reported in the
Debian BTS that the appstream xml data is wrong)
- Instead here you should record the URL of your pull request:
Bug: https://github.com/pragha-music-player/pragha/pull/125
> Last but not least, I sent this message to debian-mentors (the right
> place to ask question, right?). Please let me know if I got this
> wrong.
I think you got everything right. The debian-mentors list will
automatically receive messages sent to the RFS bug, so there is no need
to explicitly CC it (but it doesn't hurt either).
I'm not a Debian Developer so I cannot sponsor your upload. I hope you
find a sponsor soon!
Regards
Lukas
Reply to: