[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#875973: RFS: glogic/2.6-3



On Sat, Sep 16, 2017 at 07:36:18PM +0200, Innocent De Marchi wrote:
>  * Package name    : glogic
>    Version         : 2.6-3

>   Changes since the last upload:
> 
>   * New maintainer (Closes: #864582).

>     + Changed Maintainer field in debian/control file.

That's implied by "new maintainer" already.

>     + Add copyright information for debian files
>       in debian/copyright file.

Kind of also.

>     * Add Vcs-Browser and Vcs-Git on debian/control file.
>   * Standards version 4.1.0.
>     + Bumped compat level and debhelper to 10.
>   * Aplied patch write by Jakob Haufe (Closes: #782557 LP: #1422501
>     LP: #1459027).

But, what does this patch do?

>   * Aplied patch for add Keywords field to data/glogic.desktop.in file.

What about just "Add keywords to the desktop file."?  Saying where that file
is generated from in the source merely adds confusion -- anyone interested
in such a level of detail can see it in the patch.

>   * Aplied two patch to erase external HTML link.

I don't quite see what's the harm there -- it's a clickable link to the
license's text.  It doesn't get auto-fetched by any sane browser so there's
no privacy issue.


Meow!
-- 
⢀⣴⠾⠻⢶⣦⠀ I've read an article about how lively happy music boosts
⣾⠁⢰⠒⠀⣿⡁ productivity.  You can read it, too, you just need the
⢿⡄⠘⠷⠚⠋⠀ right music while doing so.  I recommend Skepticism
⠈⠳⣄⠀⠀⠀⠀ (funeral doom metal).


Reply to: