[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#874428: RFS: goldendict/1.5.0~git20160508.g92b5485-1.2 [RC, NMU]

Package: sponsorship-requests
Severity: important
X-Debbugs-CC: unera@debian.org

Dear mentors and Dmitry,

I am looking for a sponsor for Dmitry's package "goldendict". This would be an 
NMU and I would like to see it into DELAYED/7. Detailed explanations at 
bottom.

 * Package name    : goldendict
   Version         : 1.5.0~git20160508.g92b5485-1.2
   Upstream Author : Abs62 <ottomann@yandex.ru>
 * URL             : http://goldendict.org
 * License         : GPL-3+
   Section         : utils

  It builds those binary packages:

    goldendict - feature-rich dictionary lookup program

  To access further information about this package, please visit the following 
URL:

  https://mentors.debian.net/package/goldendict

  Alternatively, one can download the package with dget using this command:

    dget -x https://mentors.debian.net/debian/pool/main/g/goldendict/
goldendict_1.5.0~git20160508.g92b5485-1.2.dsc

  Debomatic build result:

    http://debomatic-amd64.debian.net/distribution#unstable/goldendict/
1.5.0~git20160508.g92b5485-1.2/buildlog

  Changes since last upload:

 goldendict (1.5.0~git20160508.g92b5485-1.2) unstable; urgency=high
 .
   * Non-maintainer upload.
   * Ack previous upload. Thank you Gianfranco!
   * Add myself into uploaders list. (Hijacking package)
   * Add watch file. (Closes: #793039)
   * Update Vcs-* field. (Closes: #864667)
   * Drop .install file. (Closes: #837677)
   * Drop .menu file as per ctte's decision.
   * Build against Qt5. (Closes: #784468)

  Source debdiff attached.

  Explanations:

Package goldendict hasn't seen any updates since Jun 2016. Bug accumulated and 
now we have RC bug (Qt4 removal). Goldendict can be built against Qt5 without 
any problems.

I have been submitting bugs/patches and pushing experimental commits into 
packaging Git repository (on collab-maint) since last year. With lots of 
emails, However, I could not get *any* reply from the original maintainer.

Now in September 2017, I decide to do some NMUs to fix lasting problems. With 
Dmitry in LowThresholdNMU list [1], I think it might be even better if I could 
be added into uploaders list as well. I use goldendict often and am willing to 
maintain this package in the long term.

Dmitry, please tell me your opinion towards the maintenance of goldendict 
package. I am more than willing to push new upstream versions or prepare NMUs 
as you wish.

For mentors interested in this package, please check this NMU again and help 
sponsor it if you find it appropriate. Any suggestions would be welcome too.

Thanks,
Boyuan Yang

[1] https://wiki.debian.org/LowThresholdNmu
diff -Nru goldendict-1.5.0~git20160508.g92b5485/debian/changelog goldendict-1.5.0~git20160508.g92b5485/debian/changelog
--- goldendict-1.5.0~git20160508.g92b5485/debian/changelog	2016-06-04 00:14:27.000000000 +0800
+++ goldendict-1.5.0~git20160508.g92b5485/debian/changelog	2017-09-06 10:44:58.000000000 +0800
@@ -1,3 +1,16 @@
+goldendict (1.5.0~git20160508.g92b5485-1.2) unstable; urgency=high
+
+  * Non-maintainer upload.
+  * Ack previous upload. Thank you Gianfranco!
+  * Add myself into uploaders list. (Hijacking package)
+  * Add watch file. (Closes: #793039)
+  * Update Vcs-* field. (Closes: #864667)
+  * Drop .install file. (Closes: #837677)
+  * Drop .menu file as per ctte's decision.
+  * Build against Qt5. (Closes: #784468)
+
+ -- Boyuan Yang <073plan@gmail.com>  Wed, 06 Sep 2017 10:44:58 +0800
+
 goldendict (1.5.0~git20160508.g92b5485-1.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru goldendict-1.5.0~git20160508.g92b5485/debian/control goldendict-1.5.0~git20160508.g92b5485/debian/control
--- goldendict-1.5.0~git20160508.g92b5485/debian/control	2015-09-23 17:25:35.000000000 +0800
+++ goldendict-1.5.0~git20160508.g92b5485/debian/control	2017-09-06 10:44:58.000000000 +0800
@@ -2,6 +2,8 @@
 Priority: optional
 Section: utils
 Maintainer: Dmitry E. Oboukhov <unera@debian.org>
+Uploaders:
+ Boyuan Yang <073plan@gmail.com>,
 Standards-Version: 3.9.6
 Build-Depends: cdbs, debhelper (>= 7),
  libeb16-dev,
@@ -13,19 +15,22 @@
  libxtst-dev,
  libbz2-dev,
  libhunspell-dev,
- libphonon-dev,
- libqt4-dev (>= 4.5.1),
- libqtwebkit-dev,
+ libphonon4qt5-dev,
+ libqt5webkit5-dev,
+ libqt5x11extras5-dev,
+ libqt5svg5-dev,
  libvorbis-dev,
  libx11-dev,
- libxtst-dev,
  pkg-config,
- qt4-qmake,
+ qtbase5-dev,
+ qttools5-dev,
+ qttools5-dev-tools,
+ qt5-qmake,
  x11proto-record-dev,
- zlib1g-dev
+ zlib1g-dev,
 Homepage: http://goldendict.org
-VCS-Browser: http://git.debian.org/?p=collab-maint/goldendict.git;a=summary
-VCS-Git: git://git.debian.org/collab-maint/goldendict.git
+Vcs-Browser: https://anonscm.debian.org/git/collab-maint/goldendict.git
+Vcs-Git: https://anonscm.debian.org/git/collab-maint/goldendict.git
 
 Package: goldendict
 Suggests: goldendict-wordnet
@@ -60,4 +65,4 @@
     translation of a word chosen from another application.
   * Support for global hotkeys. You can spawn the program window at
     any point, or directly translate a word from the clipboard.
-  * Tabbed browsing in a modern Qt 4 interface.
+  * Tabbed browsing in a modern Qt 5 interface.
diff -Nru goldendict-1.5.0~git20160508.g92b5485/debian/goldendict.install goldendict-1.5.0~git20160508.g92b5485/debian/goldendict.install
--- goldendict-1.5.0~git20160508.g92b5485/debian/goldendict.install	2015-09-23 16:22:52.000000000 +0800
+++ goldendict-1.5.0~git20160508.g92b5485/debian/goldendict.install	1970-01-01 08:00:00.000000000 +0800
@@ -1 +0,0 @@
-locale/*.qm /usr/share/apps/goldendict/locale/
diff -Nru goldendict-1.5.0~git20160508.g92b5485/debian/goldendict.menu goldendict-1.5.0~git20160508.g92b5485/debian/goldendict.menu
--- goldendict-1.5.0~git20160508.g92b5485/debian/goldendict.menu	2015-09-23 16:22:52.000000000 +0800
+++ goldendict-1.5.0~git20160508.g92b5485/debian/goldendict.menu	1970-01-01 08:00:00.000000000 +0800
@@ -1,5 +0,0 @@
-?package(goldendict):needs="X11" section="Applications/Office"\
-  title="GoldenDict" command="/usr/bin/goldendict"\
-  hints="a feature-rich dictionary lookup program" \
-  icon="/usr/share/pixmaps/goldendict.png"
-
diff -Nru goldendict-1.5.0~git20160508.g92b5485/debian/rules goldendict-1.5.0~git20160508.g92b5485/debian/rules
--- goldendict-1.5.0~git20160508.g92b5485/debian/rules	2015-09-23 16:22:52.000000000 +0800
+++ goldendict-1.5.0~git20160508.g92b5485/debian/rules	2017-09-06 10:44:58.000000000 +0800
@@ -15,7 +15,9 @@
 # include /usr/share/cdbs/1/rules/simple-patchsys.mk
 
 export PREFIX=/usr
-QMAKE		= 	qmake-qt4
+export QT_SELECT := 5
+
+#QMAKE		= 	qmake-qt5
 
 install/goldendict::
 	find debian/goldendict -type f -name '*.*' -exec chmod 0644 '{}' +
diff -Nru goldendict-1.5.0~git20160508.g92b5485/debian/watch goldendict-1.5.0~git20160508.g92b5485/debian/watch
--- goldendict-1.5.0~git20160508.g92b5485/debian/watch	1970-01-01 08:00:00.000000000 +0800
+++ goldendict-1.5.0~git20160508.g92b5485/debian/watch	2017-09-06 10:38:43.000000000 +0800
@@ -0,0 +1,5 @@
+version=4
+opts="filenamemangle=s%(?:.*?)?v?(\d[\d.]*)\.tar\.gz%goldendict-$1.tar.gz%, \
+      uversionmangle=s%-RC%~rc%" \
+      https://github.com/goldendict/goldendict/tags \
+      (?:.*?/)?v?(\d[\d.]*-?R?C?\d?).*\.tar\.gz debian uupdate
Reply to: