[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#869926: RFS: oprofile/1.2.0-1 [ITP]



Hi Andrey,


On Thu, 31 Aug 2017 22:52:12 +0500 Andrey Rahmatullin <wrar@debian.org> wrote:
> Please upgrade to the current Standards-Version.
Fixed.

> Why do you use "rm `find . -name "*.la"`" instead of "find . -name "*.la" -delete"?
Fixed

> Why do you ship static versions of the plugins?
Fixed. Don't need them, just need the .so files

> README_PACKAGERS says "It is recommended to run ldconfig in %post and
> %postun to add/remove the <libdir>/oprofile path from the standard library
> search paths.", have you checked the plugins work without adding that to
> the search paths?
Fixed. I created a file in /etc/ld.so.conf.d/ so operf with JITed code
works doing
something like:
$ operf java -Xcomp -agentlib:jvmti_oprofile Hello

I also did the changes in packages, as we talked in IRC, providing 4 packages:
oprofile, oprofile-jit, libopagent1 and libopagent-dev

> include/sstream should be documented in debian/copyright.
Fixed

> doc/*.html should ideally be rebuilt during the build process, you can
> probably achieve that by adding them to debian/clean and checking that
> they are built properly.
Fixed. I added debian/clean file

>
> --
> WBR, wRAR


Reply to: