Bug#869898: RFS: dtkcore/0.3.3-1 [ITP]

[Liang Guo <bluestonechina@gmail.com>]

On Thu, Jul 27, 2017 at 10:25 PM, ChangZhuo Chen <czchen@debian.org> wrote:
> On Thu, Jul 27, 2017 at 09:30:52PM +0800, Boyuan Yang wrote:
>>   Alioth packaging repository:
>>
>>     https://anonscm.debian.org/git/collab-maint/dtkcore.git
>
> * The copyrights in src/log/* are different from other files, please
>   check copyright header of every file and list them in
>   debian/copyright.
>
> * This symbol control file for libdtkcore.so is missing. Please help to
>   add it.

Agree, beside these problem, please notice:

* debian/docs is empty please remove

* Their should be an short license declaration in each *.{c,h,cpp}
file.  For GPL3 license files, the short license should like this:
    <one line to give the program's name and a brief idea of what it does.>
    Copyright (C) <year>  <name of author>

    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.

Please ask the original author to complete the license declaration.

* debian/copyright file should obey DEP-5 proposal[1]


[1] https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/


-- 
Liang Guo
http://guoliang.me/