[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#865560: RFS: gexiv2/0.10.6-1



On Mon, Jun 26, 2017 at 09:06:19PM +0000, Gianfranco Costamagna wrote:
> >I am looking for a sponsor for my package "gexiv2"
> 
> I sponsored in deferred/10, but I have some questions/nitpicks:
> 1) you can consider having a debian/clean file instead of overriding dh_clean

I will do this.

> 2) did you test/rebuild reverse-dependencies?

I did, and they build and run fine, but...

> 3) please fix testsuite
> http://debomatic-amd64.debian.net/distribution#unstable/gexiv2/0.10.6-1/autopkgtest

For #3 - Thank you for catching this.  This could have broken the build
of reverse dependencies.  This version adds "Requires.private: exiv2" to
the pkg-config file to make static linking easier.  It turns out that
doing this means that the .pc file won't work without exiv2.pc also
installed, even when not static linking.  I will add libexiv2-dev as a
dependency to libgexiv2-dev.

I didn't notice this when I ran the tests because I already have
libexiv2-dev installed.  I see now that I could have run the tests in an
sbuild schroot.


Reply to: