On 2017-06-14 11:50, Gianfranco Costamagna wrote:
lets review: debian/copyright has some GPL-2 packaging, why not just take the same upstream license for the packaging? lots of useless files? debian/README.source debian/README.Debian debian/service debian/env (and so on) and lots of debian files, e.g. is debian/dirs needed?(usually it is a task for the upstream build system to install directories)override_dh_installinit: dh_installinit this seems useless? :) I will continue the review after the above is fixed some CPPFLAGS seems missing? http://debomatic-amd64.debian.net/distribution#unstable/curvedns/0.87-1/blhcand some stuff is uselessly installed in the end user system (e.g. README files)(the packaging looks good, but I prefer less files to review, if something can be just deleted) G.
Little review: $ splint -I . +posixlib -preproc -standard *.c <lot>... And one memory leak :-/ $ env PERL5OPT=-m-lib=. license-reconcileCopyright mismatch: File nacl/crypto_scalarmult/curve25519/donna_c64/smult.c: Trying to match 'Google Inc.' against 'Lieuwe Jan Koning' but it does not look like a good match. at /usr/share/perl5/Debian/LicenseReconcile/App.pm line 222, <GEN0> line 3.
$ find . -type d \( -iname .bzr -o -iname .git -o -iname .hg -o -iname .svn -o -iname CVS -o -iname RCS -o -iname SCCS -o -iname _MTN -o -iname _darcs -o -iname .pc -o -iname .cabal-sandbox -o -iname .cdv -o -iname .metadata -o -iname CMakeFiles -o -iname _build -o -iname _sgbak -o -iname autom4te.cache -o -iname blib -o -iname cover_db -o -iname node_modules -o -iname '~.dep' -o -iname '~.dot' -o -iname '~.nib' -o -iname '~.plst' \) -prune -o -type f ! \( -iname '*.bak' -o -iname '*.swp' -o -iname '#.*' -o -iname '#*#' -o -iname 'core.*' -o -iname '*~' -o -iname '*.gif' -o -iname '*.jpg' -o -iname '*.jpeg' -o -iname '*.png' -o -iname '*.min.js' -o -iname '*.js.map' -o -iname '*.js.min' -o -iname '*.min.css' -o -iname '*.css.map' -o -iname '*.css.min' -o -iname '*.wav' \) -exec env PERL5OPT=-m-lib=. spellintian --picky {}
<lot, but with some false-positive> (thanks to Paul Wise for this last line :) ) Didn't try lintian/piuparts/blhc... Cheers, -- Philippe.