Hi Jörg, On Mon, 05 Jun 2017 12:00:41 +0200, Jörg Frings-Fürst <debian@jff-webhosting.net> wrote: > Alternatively, one can download the package with dget using this > command: > > dget -x > https://mentors.debian.net/debian/pool/main/libu/libunistring/libunistring_0.9.7-1.dsc Thanks for taking care of this. Here are my review notes. * I noticed you’ve added symbols files specifically for amd64 and i386; they are identical and there’s nothing there which should vary across architectures, is there any reason not to have a generic symbols file? * The contents of DEVELOP.Debian would fit nicely in a README.source instead, IMO (https://www.debian.org/doc/debian-policy/ch-source.html#s-readmesource). * Since you’re no longer using cdbs, the relevant lines in debian/rules could be entirely removed rather than commented. Regards, Stephen
Attachment:
pgpRbuqDWG6KL.pgp
Description: OpenPGP digital signature