On Thu, Jun 01, 2017 at 06:07:40PM +0800, gustavo panizzo wrote: > some tests are skipped, i feel they should run > > > perhaps usbguard should build-depend on sudo? > > UseCase/002_cli_devices.sh.log: + sudo -n dd bs=4096 count=1 if=/dev/zero of=/tmp/usbguard_disk > UseCase/002_cli_devices.sh.log: ./UseCase/002_cli_devices.sh: line 81: sudo: command not found > UseCase/002_cli_devices.sh.log: + sudo -n modprobe dummy_hcd > UseCase/002_cli_devices.sh.log: ./UseCase/002_cli_devices.sh: line 82: sudo: command not found > UseCase/002_cli_devices.sh.log: + sudo -n rmmod g_mass_storage > UseCase/002_cli_devices.sh.log: ./UseCase/002_cli_devices.sh: line 83: sudo: command not found > UseCase/002_cli_devices.sh.log: + sudo -n modprobe g_mass_storage file=/tmp/usbguard_disk iSerialNumber=555666111 > UseCase/002_cli_devices.sh.log: ./UseCase/002_cli_devices.sh: line 84: sudo: command not found > UseCase/002_cli_devices.sh.log: + '[' 127 -ne 0 ']' > UseCase/002_cli_devices.sh.log: + exit 77 > UseCase/002_cli_devices.sh.log: SKIP UseCase/002_cli_devices.sh (exit status: 77) No, it's a bad idea to do things requiring root during tests, especially modprobe/rmmod. And please remember that just calling sudo is not enough to get root. -- WBR, wRAR
Attachment:
signature.asc
Description: PGP signature