Control: tag -1 moreinfo
Control: owner -1 !
On Mon, May 15, 2017 at 10:57:36PM +0300, Коля Гурьев wrote:
> I am looking for a sponsor for my package "libtgvoip"
o/
> dget -x https://mentors.debian.net/debian/pool/main/libt/libtgvoip/libtgvoip_0.4.1~git20170514.73bf810-1.dsc
Using git as you know I prefer it :)
I fixed the HEAD on alioth to point to the debian branch (as otherwise
cloning would checkout master causing
warning: remote HEAD refers to nonexistent ref, unable to checkout.
), also could you please push some upstream tags and add an appropriate
d/gbp.conf?
Review:
* d/control:
+ Vcs-Git is wrong
+ I appreciate when Vcs-Browser is the same as Vcs-Git, given they can
be now (hint: use /git/ in both)
* d/rules:
+ why are you calling dh_install manually at the end of
dh_auto_install? it's called by dh anyway
It also fails to build for me on i386 with an error that looks like SSE2
related (but I'll let you look at it).
Otherwise it looks cool to me, but I'd like to have a correct Vcs-Git
and a working i386 build at the first upload…
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature