Control: tag -1 -moreinfo Hi Mattia, >> gbp clone --pristine-tar https://anonscm.debian.org/git/pkg-go/packages/golang-github-pkg-xattr.git > > You are doing some really bad, actually, namely defining > DEB_BUILD_OPTIONS in d/rules. I thought lintian had a check for this. > Please don't do this: either use DEB_BUILD_MAINT_OPTIONS, or add an > empty dh_auto_test override. In both cases, I would appreciate if you > could add that comment you added in the git commit message directly as a > comment to d/rules, so people can wonder less on why you disabled the > tests. OK, I added an empty dh_auto_test override. > Also, can you write a tad longer description? (lintian does complain > about this). OK, I added a few chars to make lintian happy :-). > I am not sure of the general rules within the go team, but usually I > prefer when people don't do debian/ tag unless they are 100% sure that's > what is going to be uploaded. In this case you are now forced to either > remove that tag (and then I have to manually remove it locally too…, and > so are all the people who have already cloned that repo), or bump the > version which is probably even uglier… OK, sorry about this, I'll be more careful the next time. I removed the tag and a did a forced push this time. Thanks for review, I hope I've addressed your concerns. The new version should be uploaded to mentors soon.
Attachment:
signature.asc
Description: PGP signature